Skip to content

fix: switch to re.MatchString(string) instead re.Match([]byte(string)) #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2021
Merged

fix: switch to re.MatchString(string) instead re.Match([]byte(string)) #574

merged 1 commit into from
Sep 12, 2021

Conversation

butuzov
Copy link
Contributor

@butuzov butuzov commented Sep 12, 2021 •
edited
Loading

Removes heaps allocation and unnecessary conversion, feels more "native"

@butuzov
fix: switch to re.MatchString(string) instead re.Match([]byte(string))
8bb46d5 
removes heaps allocation, feels more "native"
@mgechev mgechev merged commit 9b85893 into mgechev:master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgechev mgechev mgechev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@butuzov @mgechev