Skip to content

feat(ehr): auto close #3972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

feat(ehr): auto close #3972

merged 1 commit into from
Jun 6, 2025

Conversation

thomasyopes
Copy link
Contributor

@thomasyopes thomasyopes commented Jun 6, 2025 •
edited by coderabbitai bot
Loading

Issues:

Description

  • wrong place for auto-close

Testing

  • Local
    • auto-closes lab
  • Staging
    • N/A
  • Sandbox
    • N/A
  • Production
    • N/A

Release Plan

  • Merge this

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of lab result document submissions to ensure the autoclose setting is applied at the document level rather than per analyte.

feat(ehr): auto close
5848bc2 
Ref: ENG-296

Ref: #1040
Signed-off-by: Thomas Yopes <thomasyopes@Thomass-MBP.attlocal.net>
@linear Linear
Copy link

linear bot commented Jun 6, 2025

ENG-296 Athena Writeback for Notes, Labs, Vaccines, Allergies, and Meds

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 6, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The change updates the createLabResultDocument method in the AthenaHealth integration by moving the autoclose property from each object in the analytes array to the top-level data object in the request payload. No other logic or control flow was modified.

Changes

File(s) Change Summary
packages/core/src/external/ehr/athenahealth/index.ts Moved autoclose property from within analytes array objects to the outer data object.

Possibly related PRs

  • feat(ehr): auto close labs #3971: Also modifies the handling of the autoclose property in the createLabResultDocument method, indicating a direct relationship in the treatment of this attribute.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error code ERR_SSL_WRONG_VERSION_NUMBER
npm error errno ERR_SSL_WRONG_VERSION_NUMBER
npm error request to https://10.0.0.28:4873/punycode/-/punycode-2.3.1.tgz failed, reason: C00C72E8317F0000:error:0A00010B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:354:
npm error
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-06T16_41_43_585Z-debug-0.log

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cfa3d1d and 5848bc2.

📒 Files selected for processing (1)
  • packages/core/src/external/ehr/athenahealth/index.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@thomasyopes thomasyopes added this pull request to the merge queue Jun 6, 2025
@thomasyopes thomasyopes mentioned this pull request Jun 6, 2025
Merged
1 task
Merged via the queue into develop with commit fd98dfb Jun 6, 2025
13 of 14 checks passed
@thomasyopes thomasyopes deleted the eng-296-patch-athena branch June 6, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orta21 Orta21 Orta21 approved these changes

@Goncharo Goncharo Awaiting requested review from Goncharo Goncharo is a code owner

@leite08 leite08 Awaiting requested review from leite08 leite08 is a code owner

@RamilGaripov RamilGaripov Awaiting requested review from RamilGaripov RamilGaripov is a code owner

@lucasdellabella lucasdellabella Awaiting requested review from lucasdellabella lucasdellabella is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasyopes @Orta21