ENG-268 Consolidated search by keyword #3814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis update introduces a comprehensive refactor and modularization of the OpenSearch-based search and ingestion infrastructure for consolidated FHIR resources. Key changes include the introduction of new modules for lexical search, resource indexing, and ingestion, as well as the removal or relocation of legacy and redundant files. The API is updated to delegate consolidated patient operations to a new internal router, and environment/configuration handling is improved for search endpoints and index names. Additional enhancements include improved logging, new utility functions for text processing, and expanded test coverage for codeable concept formatting. Changes
Sequence Diagram(s)Lexical Ingestion FlowsequenceDiagram
participant API
participant IngestLexical
participant OpenSearchTextIngestor
participant S3
participant Config
API->>IngestLexical: ingestLexical({ patient, onItemError? })
IngestLexical->>Config: get OpenSearch config
IngestLexical->>OpenSearchTextIngestor: new OpenSearchTextIngestor(config)
IngestLexical->>S3: getConsolidatedAsText(patient)
IngestLexical->>OpenSearchTextIngestor: delete({ cxId, patientId })
IngestLexical->>OpenSearchTextIngestor: ingestBulk({ cxId, patientId, resources })
OpenSearchTextIngestor-->>IngestLexical: Map of error counts
IngestLexical-->>API: Log result
Lexical Search FlowsequenceDiagram
participant API
participant SearchConsolidatedDirect
participant OpenSearchLexicalSearcher
participant S3
API->>SearchConsolidatedDirect: search({ patient, query })
alt query present
SearchConsolidatedDirect->>OpenSearchLexicalSearcher: search({ cxId, patientId, query })
OpenSearchLexicalSearcher-->>SearchConsolidatedDirect: SearchResult[]
SearchConsolidatedDirect->>S3: Upload search result and query
S3-->>SearchConsolidatedDirect: Signed URL
SearchConsolidatedDirect-->>API: { url, resourceCount }
else no query
SearchConsolidatedDirect->>getConsolidatedPatientData: getConsolidatedPatientData({ patient })
getConsolidatedPatientData-->>SearchConsolidatedDirect: Bundle
SearchConsolidatedDirect->>S3: Upload result
S3-->>SearchConsolidatedDirect: Signed URL
SearchConsolidatedDirect-->>API: { url, resourceCount }
end
API Router Delegation for Consolidated Patient OperationssequenceDiagram
participant API_Router
participant PatientConsolidatedRouter
participant DB
participant OpenSearch
API_Router->>PatientConsolidatedRouter: POST /internal/patient/consolidated/query or /search/ingest
PatientConsolidatedRouter->>DB: Query/update consolidated queries, patients
PatientConsolidatedRouter->>OpenSearch: Ingest consolidated resources (if /search/ingest)
PatientConsolidatedRouter-->>API_Router: JSON response
Possibly related PRs
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm warn config production Use Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. ✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
7eca2da to
6eef068
Compare
91b6c81 to
876006a
Compare
6eef068 to
cc24edb
Compare
876006a to
207a162
Compare
207a162 to
2710ec3
Compare
cc24edb to
4af4911
Compare
2e93ca9 to
a350d94
Compare
4af4911 to
c131be2
Compare
83ca5fe to
1e795c2
Compare
This was referenced Jul 24, 2025
Closed
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
Description
Consolidated search by keyword.
Downstream PRs have
Testing
Release Plan
This has to be merged along downstream - it won't break anything is shipped without it, just that we shouldn't use the ingestion/search in production w/o downstream.
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Refactor
Chores