Skip to content

ENG-200 Remove Org e2e tests #4440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2025
Merged

ENG-200 Remove Org e2e tests #4440

merged 1 commit into from
Aug 21, 2025

Conversation

RamilGaripov
Copy link
Contributor

@RamilGaripov RamilGaripov commented Aug 21, 2025 •
edited by coderabbitai bot
Loading

Part of ENG-000

Description

  • Organization routes were removed, so let's also get rid of the e2e tests

Testing

  • Local
    • Run the e2e tests locally to make sure everything else passes

Release Plan

  • Merge this

Summary by CodeRabbit

  • Tests
    • Removed Organization end-to-end tests from the MAPI suite, including related helpers and scenarios for retrieving and updating organizations across local and FHIR integrations.
    • No new tests added; other test areas remain unchanged.
    • Reduces test coverage for the Organization resource while keeping the rest of the suite intact.
    • No user-facing changes; application behavior and builds are unaffected.

@RamilGaripov
fix(api): remove org level e2e tests
c178606 
Part of ENG-000

Signed-off-by: RamilGaripov <ramil@metriport.com>
@RamilGaripov RamilGaripov changed the title ENG-xxx ...WIP ENG-000 Remove Org e2e tests Aug 21, 2025
@RamilGaripov RamilGaripov marked this pull request as ready for review August 21, 2025 18:59
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 21, 2025 •
edited
Loading

Walkthrough

Removed Organization-related E2E tests from the MAPI test suite by deleting the organization test part file and its invocation/import in the main MAPI E2E runner. No other tests or public APIs were modified.

Changes

Cohort / File(s) Summary
MAPI E2E suite adjustments
packages/api/src/__tests__/e2e/mapi/mapi.test.e2e.ts		 Removed import and describe block that executed Organization E2E tests.
Organization E2E part removal
packages/api/src/__tests__/e2e/mapi/parts/organization.test.part.ts		 Deleted file containing Organization E2E tests and helper functions, including exported runOrganizationTests().

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled
  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e6af631 and c178606.

📒 Files selected for processing (2)
  • packages/api/src/__tests__/e2e/mapi/mapi.test.e2e.ts (0 hunks)
  • packages/api/src/__tests__/e2e/mapi/parts/organization.test.part.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/api/src/tests/e2e/mapi/mapi.test.e2e.ts
  • packages/api/src/tests/e2e/mapi/parts/organization.test.part.ts
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch eng-000-remove-org-e2e
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

leite08
leite08 approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@leite08 leite08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ticket is ENG-200

@RamilGaripov RamilGaripov added this pull request to the merge queue Aug 21, 2025
Merged via the queue into develop with commit bb9e57f Aug 21, 2025
17 checks passed
@RamilGaripov RamilGaripov deleted the eng-000-remove-org-e2e branch August 21, 2025 19:10
@RamilGaripov RamilGaripov changed the title ENG-000 Remove Org e2e tests ENG-200 Remove Org e2e tests Aug 21, 2025
@linear Linear
Copy link

linear bot commented Aug 21, 2025

ENG-200 Scope CW v2 + SDK development

@RamilGaripov RamilGaripov mentioned this pull request Aug 21, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leite08 leite08 leite08 approved these changes

@lucasdellabella lucasdellabella lucasdellabella approved these changes

@Goncharo Goncharo Awaiting requested review from Goncharo Goncharo is a code owner

@Orta21 Orta21 Awaiting requested review from Orta21 Orta21 is a code owner

@thomasyopes thomasyopes Awaiting requested review from thomasyopes thomasyopes is a code owner

@keshavsaharia keshavsaharia Awaiting requested review from keshavsaharia keshavsaharia is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RamilGaripov @leite08 @lucasdellabella