Skip to content

RELEASE: Deduplication fix for MedicationDispense #4077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2025
Merged

RELEASE: Deduplication fix for MedicationDispense #4077

merged 2 commits into from
Jun 21, 2025

Conversation

keshavsaharia
Copy link
Contributor

@keshavsaharia keshavsaharia commented Jun 21, 2025 •
edited by coderabbitai bot
Loading

Issues:

Dependencies

  • Upstream: None
  • Downstream: None

Description

Testing

Check each PR.

Release Plan

  • ⚠️ Points to master
  • Merge this

Summary by CodeRabbit

  • New Features
    • Added support for handling and deduplicating MedicationDispense resources in FHIR bundles.
  • Bug Fixes
    • Ensured MedicationDispense resources are correctly processed alongside other medication-related resources during deduplication.

keshavsaharia and others added 2 commits June 20, 2025 19:47
@keshavsaharia
fix(core): fix to deduplication to avoid breaking references for Medi…
12eb5fe 
…cationDispense

metriport/metriport-internal#1040

Signed-off-by: Keshav Saharia <keshav@metriport.com>
@keshavsaharia
Merge pull request #4076 from metriport/eng-498-medicationdispense-de…
66cfe95 
…duplication

fix(core): Fix deduplication to properly handle references for MedicationDispense
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 21, 2025 •
edited
Loading

Walkthrough

Support for the FHIR resource type MedicationDispense was added to both the bundle extraction and deduplication processes. The extraction function now collects MedicationDispense resources, and the deduplication logic includes them in medication-related processing and reference replacement.

Changes

File(s) Change Summary
packages/core/src/external/fhir/bundle/bundle.ts Added extraction and collection of MedicationDispense resources in extractFhirTypesFromBundle.
packages/core/src/fhir-deduplication/deduplicate-fhir.ts Included MedicationDispense in medication-related deduplication and reference replacement logic.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant BundleExtractor
    participant Deduplicator

    Client->>BundleExtractor: extractFhirTypesFromBundle(bundle)
    BundleExtractor-->>Client: { medicationDispenses, ...otherResources }

    Client->>Deduplicator: deduplicateFhirTypes({ medicationDispenses, ... })
    Deduplicator->>Deduplicator: Deduplicate medication resources
    Deduplicator->>Deduplicator: Replace medication references in medicationDispenses
    Deduplicator-->>Client: Deduplicated resources
Loading

Possibly related PRs

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error code ERR_SSL_WRONG_VERSION_NUMBER
npm error errno ERR_SSL_WRONG_VERSION_NUMBER
npm error request to https://10.0.0.28:4873/punycode/-/punycode-2.3.1.tgz failed, reason: C0ECF844277F0000:error:0A00010B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:354:
npm error
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-21T19_29_13_139Z-debug-0.log

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 753d596 and 66cfe95.

📒 Files selected for processing (2)
  • packages/core/src/external/fhir/bundle/bundle.ts (2 hunks)
  • packages/core/src/fhir-deduplication/deduplicate-fhir.ts (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.ts`: - Use the Onion Pattern to organize a package's code in layers - Try to use immutable code and avoid sharing state across different functions, objects, and systems - Try...

**/*.ts: - Use the Onion Pattern to organize a package's code in layers

  • Try to use immutable code and avoid sharing state across different functions, objects, and systems
  • Try to build code that's idempotent whenever possible
  • Prefer functional programming style functions: small, deterministic, 1 input, 1 output
  • Minimize coupling / dependencies
  • Avoid modifying objects received as parameter
  • Only add comments to code to explain why something was done, not how it works
  • Naming
    • classes, enums: PascalCase
    • constants, variables, functions: camelCase
    • file names: kebab-case
    • table and column names: snake_case
    • Use meaningful names, so whoever is reading the code understands what it means
    • Don’t use negative names, like notEnabled, prefer isDisabled
    • For numeric values, if the type doesn’t convey the unit, add the unit to the name
  • Typescript
    • Use types
    • Prefer const instead of let
    • Avoid any and casting from any to other types
    • Type predicates: only applicable to narrow down the type, not to force a complete type conversion
    • Prefer deconstructing parameters for functions instead of multiple parameters that might be of
      the same type
    • Don’t use null inside the app, only on code interacting with external interfaces/services,
      like DB and HTTP; convert to undefined before sending inwards into the code
    • Use async/await instead of .then()
    • Use the strict equality operator ===, don’t use abstract equality operator ==
    • When calling a Promise-returning function asynchronously (i.e., not awaiting), use .catch() to
      handle errors (see processAsyncError and emptyFunction depending on the case)
    • Date and Time
      • Always use buildDayjs() to create dayjs instances
      • Prefer dayjs.duration(...) to create duration consts and keep them as duration
  • Prefer Nullish Coalesce (??) than the OR operator (||) to provide a default value
  • Avoid creating arrow functions
  • Use truthy syntax instead of in - i.e., if (data.link) not if ('link' in data)
  • Error handling
    • Pass the original error as the new one’s cause so the stack trace is persisted
    • Error messages should have a static message - add dynamic data to MetriportError's additionalInfo prop
    • Avoid sending multiple events to Sentry for a single error
  • Global constants and variables
    • Move literals to constants declared after imports when possible (avoid magic numbers)
    • Avoid shared, global objects
  • Avoid using console.log and console.error in packages other than utils, infra and shared,
    and try to use out().log instead
  • Avoid multi-line logs
    • don't send objects as a second parameter to console.log() or out().log()
    • don't create multi-line strings when using JSON.stringify()
  • Use eslint to enforce code style
  • Use prettier to format code
  • max column length is 100 chars
  • multi-line comments use /** */
  • scripts: top-level comments go after the import
  • packages/core/src/fhir-deduplication/deduplicate-fhir.ts
  • packages/core/src/external/fhir/bundle/bundle.ts
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: check-pr / lint-build-test
  • GitHub Check: Analyze (javascript)
  • GitHub Check: e2e-tests / E2E Tests
🔇 Additional comments (7)
packages/core/src/external/fhir/bundle/bundle.ts (4)

22-22: LGTM! Import added correctly.

The MedicationDispense import follows the alphabetical ordering and is properly typed.

384-384: LGTM! Array declaration follows established pattern.

The medicationDispenses array declaration is consistent with other resource arrays and uses proper TypeScript typing.

420-422: LGTM! Resource extraction logic is correct.

The MedicationDispense extraction follows the same pattern as other resource types with proper type checking and casting.

502-502: LGTM! Properly positioned in return object.

The medicationDispenses array is correctly included in the returned ExtractedFhirTypes object and appropriately grouped with other medication-related arrays.

packages/core/src/fhir-deduplication/deduplicate-fhir.ts (3)

35-35: LGTM! Correctly categorizes MedicationDispense as medication-related.

Adding MedicationDispense to the medicationRelatedTypes array is appropriate and ensures proper handling in medication reference filtering logic.

64-64: LGTM! Ensures medication references are updated in MedicationDispense resources.

Including "medicationDispenses" in the reference replacement ensures that medication references within MedicationDispense resources are properly updated after medication deduplication.

60-76: Verify if MedicationDispense needs dedicated deduplication logic.

While MedicationDispense is correctly added to reference replacement, I notice that other medication-related resources (MedicationAdministration, MedicationRequest, MedicationStatement) have dedicated deduplication functions called in this section. There's no corresponding deduplication call for MedicationDispense.

Please verify if MedicationDispense resources should have their own deduplication logic:

#!/bin/bash
# Description: Check if there's a deduplication function for MedicationDispense

# Search for MedicationDispense deduplication functions
echo "=== Searching for MedicationDispense deduplication functions ==="
rg -A 5 "deduplicat.*MedicationDispense|MedicationDispense.*deduplicat" --type ts

echo -e "\n=== Checking existing medication deduplication functions ==="
fd "medication.*\.ts$" packages/core/src/fhir-deduplication/resources/ --exec basename {}

echo -e "\n=== Checking if MedicationDispense has similar structure to other medication resources ==="
ast-grep --pattern 'function deduplicateMed$_($$$) { $$$ }'
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@keshavsaharia keshavsaharia marked this pull request as ready for review June 21, 2025 19:28
@keshavsaharia keshavsaharia enabled auto-merge June 21, 2025 19:37
@keshavsaharia keshavsaharia added this pull request to the merge queue Jun 21, 2025
Merged via the queue into master with commit 2904bbd Jun 21, 2025
65 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jun 25, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goncharo Goncharo Goncharo approved these changes

@leite08 leite08 Awaiting requested review from leite08 leite08 is a code owner

@Orta21 Orta21 Awaiting requested review from Orta21 Orta21 is a code owner

@RamilGaripov RamilGaripov Awaiting requested review from RamilGaripov RamilGaripov is a code owner

@thomasyopes thomasyopes Awaiting requested review from thomasyopes thomasyopes is a code owner

@lucasdellabella lucasdellabella Awaiting requested review from lucasdellabella lucasdellabella is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keshavsaharia @Goncharo