Let each metric configure itself, and encapsulate its configuration #91
Conversation
| # graph_engine_options :bluff | ||
|
|
||
| # @param metric_name [Symbol] | ||
| def metric(metric) |
There was a problem hiding this comment.
Not sure if this should be class_level or not. I haven't settled on what should be exposed to the outside and at what level it should be configured or re-configured
| @@ -6,7 +6,7 @@ def title | |||
| end | |||
| def data | |||
| [ | |||
| ['rails_best_practices', @rails_best_practices.join(',')] | |||
| ['rails_best_practices', @rails_best_practices_count.join(',')] | |||
There was a problem hiding this comment.
bug fix to pull into its own PR
There was a problem hiding this comment.
ah, heh, now I see that you already caught this as well.
| MetricFu.configuration.metrics -= [ metric ] | ||
| MetricFu.configuration.graphs -= [ metric ] | ||
| mf_debug "active metrics are #{MetricFu.configuration.metrics.inspect}" | ||
| MetricFu::Metrics.get_metric(metric).enabled = false |
There was a problem hiding this comment.
I think this should be MetricFu::Metric.get_metric... (rather than Metrics)?
|
@bf4 - working on the "Too many open files" issue. Trying to repro so I can be certain I've fixed the problem. Can you give me an idea of how big the project is that you are seeing this on, as well as ruby version? |
|
@robincurry cruby 1.9.3-p448 with rvm, reasonably sized legacy rails project |
Conflicts: spec/spec_helper.rb
Conflicts: lib/metric_fu/io.rb
|
Let's talk about which PR should be closed / worked on and merged and where to summarize notes for going forward. |
No description provided.