Replace native rails stats task with extract gem version #108
Conversation
|
Great stuff! Love that this will allow us to run stats on non-rails code-bases. |
|
Breaking a few tests, but other than that, looks good. Yeah, if we don't need the mf-stats task, I say get rid of it. |
|
@robincurry oh yeah.. tests... |
|
Nice +1, rails stats has always been a bit limited anyways, so having a more robust stats is definitely a win. Back in the day we had to pull this out as well so we could run stats on non rails projects, which was a big win. https://github.com/devver/code_statistics I also think we could really improve on the basic stats. I have always wanted a breakdown of the view layer in terms of % css, JS, markup, and code_in_markup (which should be kept to a minimum). |
|
@danmayer Thanks. Don't know if you caught, but this gem is intended to be a sanctioned extraction of the rails code. bf4/code_metrics#2 |
|
Nice very cool. I actually attempted some rails patches related to stats years ago when we found some bugs in it, but could never push them through. This looks like it has a good chance of getting merged in, which would be great. |
|
@danmayer Señor Klabnik informs me, in a communication, there is a discussion about it on the rails maintainers list but I have no insight into what is going on... frustrating... Let me know if you want to work on it over there.. there's plenty of room for improvement :) |
|
Tests pass |
Replace native rails stats task with extracted gem version
Benefits:
rake stats, there's no requirement for the current directory to be bundled and for rake to need to be successfully activated