Skip to content

Exception for already closed notes and allow empty notes responses #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 18, 2023
Merged

Exception for already closed notes and allow empty notes responses #138

merged 3 commits into from
Jan 18, 2023

Conversation

metaodi
Copy link
Owner

@metaodi metaodi commented Jan 17, 2023 •
edited
Loading

Fixes #135
Fixes #137

@metaodi metaodi marked this pull request as ready for review January 18, 2023 12:37
@metaodi metaodi changed the title WIP: Note already closed error Exception for already closed notes and allow empty notes responses Jan 18, 2023
@metaodi metaodi merged commit 6777da7 into develop Jan 18, 2023
@metaodi metaodi deleted the note-already-closed-error branch January 18, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

empty notes list crashes api more specific exception than osmapi.OsmApi.ApiError for already closed note
1 participant
@metaodi