Fix temporal string definitions #55270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranquild
approved these changes
Mar 17, 2025
sloansparger
approved these changes
Mar 17, 2025
e2e tests failed on
|
| File | Test Name |
|---|---|
dashboard.cy.spec.js |
(flaky) scenarios > dashboard > warn before leave > should warn a user before leaving after adding, removed, moving, or duplicating a tab |
line-bar-tooltips.cy.spec.js |
(flaky) scenarios > visualizations > line/bar chart > tooltips > should be enterable and scollable to view all rows in long tooltips (#53586) (#48347) |
stasgavrylov
approved these changes
Mar 17, 2025
rafpaf
reviewed
Mar 17, 2025
| @@ -30,15 +30,15 @@ export function getShortcutGroups(): ShortcutGroup[] { | |||
| columns: 3, | |||
| shortcuts: [ | |||
| { | |||
| label: t`Week`, | |||
| label: ngettext(msgid`Week`, `Weeks`, 1), | |||
There was a problem hiding this comment.
Maybe write a doc string explaining this unusual code?
There was a problem hiding this comment.
i think it would be spammy. I updated the PR description to explain it a little more, so people can get there via blame if they need
github-automation-metabase
pushed a commit
that referenced
this pull request
Mar 17, 2025
|
|
iethree
added a commit
that referenced
this pull request
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix string definitions for Day, Month, and Year to be compatible with backend strings.
This will fix this error in the i18n job.
The developer ergonomics here aren't great, but we can't just define a singular where a plural exists on the backend, we have to define the localization string to say "use the singular form of this singular/plural group"