Polishing 2025: Fix width of model persistence toggle #55121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Admin / Performance / Model persistence, don't allow the toggle to fill the width of the page or clicking several inches to the right of it will trigger it, making misclicks too easy.
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
e2e tests failed on
|
| File | Test Name |
|---|---|
dashboard.cy.spec.js |
(flaky) scenarios > dashboard > warn before leave > should warn a user before leaving after adding, removed, moving, or duplicating a tab |
reproductions.cy.spec.ts |
(flaky) issue 39487 > calendar has constant size when using single date picker filter (#39487) |
reproductions.cy.spec.ts |
(flaky) issue 39487 > calendar has constant size when using date range picker filter (#39487) |
line-bar-tooltips.cy.spec.js |
(flaky) scenarios > visualizations > line/bar chart > tooltips > should be enterable and scollable to view all rows in long tooltips (#53586) (#48347) |
|
|
kdoh
approved these changes
Mar 14, 2025
sloansparger
approved these changes
Mar 17, 2025
29a52ab
into
rkl/polishing-2025/integration
154 of 158 checks passed
github-automation-metabase
pushed a commit
that referenced
this pull request
Mar 21, 2025
In Admin / Performance / Model persistence, don't allow the toggle to fill the width of the page or clicking several inches to the right of it will trigger it, making misclicks too easy.
github-automation-metabase
added a commit
that referenced
this pull request
Mar 21, 2025
In Admin / Performance / Model persistence, don't allow the toggle to fill the width of the page or clicking several inches to the right of it will trigger it, making misclicks too easy. Co-authored-by: Raphael Krut-Landau <raphael.kl@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Admin / Performance / Model persistence, don't allow the toggle to fill the width of the page or clicking several inches to the right of it will trigger it, making misclicks too easy.
Before:
After