fix(parser): get/set/from/of are allowed as identifiers #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giles-v
reviewed
Apr 3, 2025
| import { version as pkgVersion } from '../package.json'; | ||
|
|
||
| // This bypass troublesome package.json in generated d.ts file. | ||
| const version: string = pkgVersion; |
There was a problem hiding this comment.
I assume this is a fix for #375? Curious why -- the error I got from TypeScript was a failure to resolve the ../package.json import, which will still happen here. Looks like my report wasn't specific enough.
There was a problem hiding this comment.
This lets typescript to skip reference of package.json in generated d.ts file.
import { Options } from './parser';
import * as ESTree from './estree';
declare const version: string;
export declare function parseScript(source: string, options?: Options): ESTree.Program;
export declare function parseModule(source: string, options?: Options): ESTree.Program;
export declare function parse(source: string, options?: Options): ESTree.Program;
export { Options, ESTree, version };
fisker
approved these changes
Apr 4, 2025
|
v6.0.6 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #376