Skip to content

Fix calculateCommissionLinesStep having udnefined computed totals values #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

NicolasGorga
Copy link
Contributor

If one of the cmputed totals fields are not included in the select of OrderModule main service methods, then the order is not decorated with Totals.

Captura de pantalla 2025-03-17 a la(s) 6 21 21 p  m

Also, corrected the names of the computed totals fields, when being accessed through the items relation.

@slusarczykmichal slusarczykmichal merged commit 8d17158 into mercurjs:main Mar 18, 2025
1 check failed
@NicolasGorga NicolasGorga deleted the fix/commission-line-undefined-prices branch March 22, 2025 12:48
siyamchunu pushed a commit to siyamchunu/212manager that referenced this pull request Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants