fix: Allow equals sign in sequenceDiagram labels #6332
Conversation
🦋 Changeset detectedLatest commit: 6cc1926 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6332 +/- ##
=======================================
Coverage 3.88% 3.88%
=======================================
Files 398 398
Lines 42044 42044
Branches 638 638
=======================================
Hits 1635 1635
Misses 40409 40409
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
@sidharthv96 @ashishjain0512 Could either of you please take a look? Looks like a straightforward fix. This is one of the issues that will help us upgrade Mermaid from v10.x to v11.x easily in GitLab: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/171452 |
b773fd5 to
6cc1926
Compare
|
@sidharthv96 @ashishjain0512 I've added a changeset, rebased the change on top of latest Ideally, this PR and #6345 could be merged before the next release. I believe these two PRs would be sufficient to allow GitLab to more easily adopt the 11.x series. |
|
@sidharthv96 @knsv @shubhamparikh2704 This PR not moving forward is becoming quite a blocker for GitLab and the GitLab community to upgrade from mermaid 10.x to 11.x, despite users asking for it. For an overview of the discussions in that community see here and here Can any of you have a look at this PR and tell @ajuckel what is needed to move this forward? |
|
Checking |
|
@ajuckel, Thank you for the contribution! |
📑 Summary
Resolves the issue where equals sign was accidentally disallowed in sequence diagram participants.
Resolves #6171
📏 Design Decisions
Commit e852156 unintentionally changed an escaped hyphen in a regex character class to an escaped left-angle-bracket followed by an un-escaped hyphen. Rather than disallowing <, -, and >, this change inadvertently disallowed characters
<through>. Nestled in between<and>in the ASCII characters is=.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.