Skip to content

Conversation

darshanr0107
Copy link
Contributor

@darshanr0107 darshanr0107 commented Aug 21, 2025

📑 Summary

This PR fixes an issue where bidirectional arrows (<<->>) were rendered incorrectly when auto number was enabled in sequence diagrams.

Resolves #6721

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Aug 21, 2025

🦋 Changeset detected

Latest commit: e0b45c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mermaid Patch
@mermaid-js/examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Aug 21, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit e0b45c2
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/68a72301fa9f210008d6aa99
😎 Deploy Preview https://deploy-preview-6886--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

pkg-pr-new bot commented Aug 21, 2025

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@6886

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@6886

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6886

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6886

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6886

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@6886

commit: e0b45c2

Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.70%. Comparing base (bf3ca9d) to head (e0b45c2).
⚠️ Report is 80 commits behind head on develop.

Files with missing lines Patch % Lines
.../mermaid/src/diagrams/sequence/sequenceRenderer.ts 0.00% 19 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6886      +/-   ##
==========================================
- Coverage     3.70%   3.70%   -0.01%     
==========================================
  Files          455     455              
  Lines        44901   45022     +121     
  Branches       709     709              
==========================================
+ Hits          1664    1668       +4     
- Misses       43237   43354     +117     
Flag Coverage Δ
unit 3.70% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../mermaid/src/diagrams/sequence/sequenceRenderer.ts 0.07% <0.00%> (-0.01%) ⬇️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
Copy link

argos-ci bot commented Aug 21, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 4 changed, 1 added Aug 21, 2025, 2:03 PM

@shubhamparikh2704 shubhamparikh2704 added this pull request to the merge queue Aug 21, 2025
github-merge-queue bot pushed a commit that referenced this pull request Aug 21, 2025
…ender-incorrectly-with-autonumber-in-sequence-diagrams

6721: Correct rendering of bidirectional arrows with auto number
@shubhamparikh2704 shubhamparikh2704 removed this pull request from the merge queue due to a manual request Aug 21, 2025
@shubhamparikh2704 shubhamparikh2704 added this pull request to the merge queue Aug 21, 2025
Merged via the queue into develop with commit 29886b8 Aug 21, 2025
25 checks passed
@shubhamparikh2704 shubhamparikh2704 deleted the 6721/Bidirectional-arrows--render-incorrectly-with-autonumber-in-sequence-diagrams branch August 21, 2025 16:07
@github-actions github-actions bot mentioned this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bidirectional arrows (<<->>) render incorrectly with autonumber in sequence diagrams
2 participants