Skip to content

Exposing elk configuration forceNodeModelOrder and considerMode… #6857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2025
Merged

Exposing elk configuration forceNodeModelOrder and considerMode… #6857

merged 2 commits into from
Aug 14, 2025

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Aug 14, 2025

📑 Summary

Exposing elk configuration forceNodeModelOrder and considerModelOrder to the mermaid configuration

Resolves #6856

📏 Design Decisions

Added to the configuration schema.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • [ x 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 5cc264f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@mermaid-js/layout-elk Patch
mermaid Patch
@mermaid-js/examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Aug 14, 2025 •
edited
Loading

✅ Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 5cc264f
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/689dc30fcad65300089adbc1
😎 Deploy Preview https://deploy-preview-6857--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 14, 2025 •
edited
Loading

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@6857

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@6857

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6857

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6857

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6857

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@6857

commit: 5cc264f

@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.71%. Comparing base (91d7229) to head (5cc264f).
⚠️ Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
packages/mermaid-layout-elk/src/render.ts 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6857      +/-   ##
==========================================
+ Coverage     3.69%   3.71%   +0.01%     
==========================================
  Files          455     455              
  Lines        44979   44894      -85     
  Branches       709     709              
==========================================
+ Hits          1664    1666       +2     
+ Misses       43315   43228      -87
Flag Coverage Δ
unit 3.71% <40.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/config.type.ts 100.00% <ø> (ø)
packages/mermaid/src/defaultConfig.ts 40.75% <100.00%> (+0.56%) ⬆️
packages/mermaid-layout-elk/src/render.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sidharthv96 sidharthv96 enabled auto-merge August 14, 2025 11:06
@argos-ci Argos CI
Copy link

argos-ci bot commented Aug 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Aug 14, 2025, 11:19 AM

@sidharthv96 sidharthv96 added this pull request to the merge queue Aug 14, 2025
Merged via the queue into develop with commit e6ee145 Aug 14, 2025
25 checks passed
@sidharthv96 sidharthv96 deleted the elk-exposing-considerModelOrder-to-config branch August 14, 2025 11:29
This was referenced Aug 19, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthv96 sidharthv96 sidharthv96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose elk configuration forceNodeModelOrder and considerModelOrder to the mermaid configuration
2 participants
@knsv @sidharthv96