-
-
Notifications
You must be signed in to change notification settings - Fork 8k
fix: fallback to raw text instead of rendering *Unsupported markdown* #6855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 6a6289f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6855 +/- ##
=======================================
Coverage 3.69% 3.70%
=======================================
Files 455 455
Lines 44979 44894 -85
Branches 709 709
=======================================
Hits 1664 1664
+ Misses 43315 43230 -85
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
into sidv/showRawData * 'sidv/showRawData' of https://github.com/mermaid-js/mermaid: Create strong-laws-confess.md
Co-authored-by: Alois Klink <alois@mermaidchart.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'd rather add a bit more info to the changeset, but that's a personal preference thing, so feel free to ignore it.
Co-authored-by: Alois Klink <alois@aloisklink.com>
📑 Summary
Instead of saying "Unsupported markdown", we show the raw text when
htmlLabels: true
(the default behavior)Before

After

Resolves #
📏 Design Decisions
Prevents data loss
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.