Skip to content

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Aug 14, 2025

📑 Summary

Instead of saying "Unsupported markdown", we show the raw text when htmlLabels: true (the default behavior)

Before
image

After
image

Resolves #

📏 Design Decisions

Prevents data loss

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Aug 14, 2025

🦋 Changeset detected

Latest commit: 6a6289f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mermaid Patch
@mermaid-js/examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 6a6289f
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/689dbf17caab8b00085dd8be
😎 Deploy Preview https://deploy-preview-6855--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

pkg-pr-new bot commented Aug 14, 2025

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@6855

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@6855

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6855

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6855

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6855

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@6855

commit: 6a6289f

Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.70%. Comparing base (ce99634) to head (6a6289f).
⚠️ Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
...mermaid/src/rendering-util/handle-markdown-text.ts 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6855   +/-   ##
=======================================
  Coverage     3.69%   3.70%           
=======================================
  Files          455     455           
  Lines        44979   44894   -85     
  Branches       709     709           
=======================================
  Hits          1664    1664           
+ Misses       43315   43230   -85     
Flag Coverage Δ
unit 3.70% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...mermaid/src/rendering-util/handle-markdown-text.ts 1.25% <0.00%> (-0.07%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

argos-ci bot commented Aug 14, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 2 added Aug 14, 2025, 11:02 AM

@sidharthv96 sidharthv96 changed the title fix: Remove data loss when unsupported markdown is encountered fix: fallback to raw text instead of rendering *Unsupported markdown* Aug 14, 2025
Copy link
Member

@aloisklink aloisklink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'd rather add a bit more info to the changeset, but that's a personal preference thing, so feel free to ignore it.

@aloisklink aloisklink enabled auto-merge August 14, 2025 10:41
@sidharthv96 sidharthv96 disabled auto-merge August 14, 2025 10:42
@aloisklink aloisklink enabled auto-merge August 14, 2025 10:59
@aloisklink aloisklink added this pull request to the merge queue Aug 14, 2025
Merged via the queue into develop with commit 690cc73 Aug 14, 2025
25 checks passed
@aloisklink aloisklink deleted the sidv/showRawData branch August 14, 2025 11:13
This was referenced Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants