Skip to content

Saurabh/fix-node-border-style-for-hand-drawn-shapes #6838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 8, 2025
Merged

Saurabh/fix-node-border-style-for-hand-drawn-shapes #6838

merged 3 commits into from
Aug 8, 2025

Conversation

saurabhg772244
Copy link
Contributor

@saurabhg772244 saurabhg772244 commented Aug 8, 2025 •
edited
Loading

📑 Summary

  • Node borders style stroke-dasharray was getting ignored in hand drawn shapes.
  • Added a function to get stroke styles.

Resolves #

📏 Design Decisions

  • getStrokeDashArray: a function to get strokeLineDash property from roughjs.
  • By default if style is not provided it will be [0, 0] ie single line.
  • stroke-dasharray can be a single value or two values eg stroke-dasharray : 5 or stroke-dasharray: 5 5. Handled both cases.

Note

  • We do have a test for stroke-dasharray in flowchart-handDrawn which was giving single line now it will give proper dashed line.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2025

🦋 Changeset detected

Latest commit: 4d62d59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mermaid Patch
@mermaid-js/examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Aug 8, 2025 •
edited
Loading

✅ Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 4e55a45
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/6895df3eebeca10008ac880c
😎 Deploy Preview https://deploy-preview-6838--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 8, 2025 •
edited
Loading

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@6838

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@6838

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6838

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6838

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6838

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@6838

commit: 4e55a45

@codecov Codecov
Copy link

codecov bot commented Aug 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.70%. Comparing base (3d31982) to head (4e55a45).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
.../rendering-elements/shapes/handDrawnShapeStyles.ts 0.00% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6838   +/-   ##
=======================================
  Coverage     3.70%   3.70%           
=======================================
  Files          455     454    -1     
  Lines        44887   44877   -10     
  Branches       709     709           
=======================================
  Hits          1664    1664           
+ Misses       43223   43213   -10
Flag Coverage Δ
unit 3.70% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../rendering-elements/shapes/handDrawnShapeStyles.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@argos-ci Argos CI
Copy link

argos-ci bot commented Aug 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 49 changed Aug 8, 2025, 11:38 AM

sidharthv96

This comment was marked as resolved.

Sign in to view

@sidharthv96 sidharthv96 added this pull request to the merge queue Aug 8, 2025
Merged via the queue into mermaid-js:develop with commit 2fe3063 Aug 8, 2025
22 checks passed
This was referenced Aug 19, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthv96 sidharthv96 sidharthv96 approved these changes

@omkarht omkarht omkarht approved these changes

Assignees
No one assigned
Labels
Sponsored by MermaidChart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saurabhg772244 @sidharthv96 @omkarht @shubhamparikh2704