Skip to content

Conversation

darshanr0107
Copy link
Contributor

@darshanr0107 darshanr0107 commented Aug 6, 2025

📑 Summary

This PR updates the block diagram rendering logic to correctly interpret --- as a non-directional line, ensuring that arrows are not added for this syntax.

Resolves #6611

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
Copy link

changeset-bot bot commented Aug 6, 2025

🦋 Changeset detected

Latest commit: 165ffef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mermaid Patch
@mermaid-js/examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 165ffef
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/68944a3e60309e00089b7234
😎 Deploy Preview https://deploy-preview-6833--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

pkg-pr-new bot commented Aug 6, 2025

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@6833

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@6833

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6833

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6833

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6833

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@6833

commit: 165ffef

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.71%. Comparing base (d93d9a5) to head (165ffef).
⚠️ Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/block/blockDB.ts 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6833   +/-   ##
=======================================
  Coverage     3.70%   3.71%           
=======================================
  Files          455     454    -1     
  Lines        44776   44754   -22     
  Branches       708     708           
=======================================
  Hits          1661    1661           
+ Misses       43115   43093   -22     
Flag Coverage Δ
unit 3.71% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/block/blockDB.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

argos-ci bot commented Aug 6, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 added Aug 7, 2025, 6:50 AM

@shubhamparikh2704
Copy link
Member

@darshanr0107 Please check the argos, the arrows doesn't look correct

on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@knsv knsv added this pull request to the merge queue Aug 8, 2025
Merged via the queue into develop with commit 074701e Aug 8, 2025
25 checks passed
@knsv knsv deleted the 6611-block-diagram-arrow-direction branch August 8, 2025 07:35
This was referenced Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block diagram shows incorrect arrow direction
3 participants