-
-
Notifications
You must be signed in to change notification settings - Fork 8k
fix: add classLiteral to the language for class diagram namespace #6820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add classLiteral to the language for class diagram namespace #6820
Conversation
🦋 Changeset detectedLatest commit: c99bce6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6820 +/- ##
=========================================
Coverage ? 3.71%
=========================================
Files ? 454
Lines ? 44752
Branches ? 708
=========================================
Hits ? 1661
Misses ? 43091
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Hi @kriss-u , thansk for the contribution. PR looks great. Can you also add visual test for this. |
cac4ae0
to
c99bce6
Compare
Yeah. @shubhamparikh2704 I added one. |
📑 Summary
This PR adds
classLiteralName
on the class diagram's language. This allows backticks on namespace label which seems reasonable to do.I have also added a test case to not throw if backticks used on the namespace for class diagrams.
Now, this is valid syntax.
Outputs to:
Resolves #6815
📏 Design Decisions
This is a straightforward change to add
classLiteralName
in the language definition of namespace.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.