Skip to content

Fix: zenuml rendering #6798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 29, 2025
Merged

Fix: zenuml rendering #6798

merged 6 commits into from
Jul 29, 2025

Conversation

MrCoder
Copy link
Contributor

@MrCoder MrCoder commented Jul 27, 2025

📑 Summary

Upgrade @zenuml/core to v3.35.2.

Resolves mermaid-live-editor#1760

📏 Design Decisions

Between v3.32.3 and 3.35.1, there was a timing issue that cause the diagram not being rendered. The element was copied before rendering is done.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

MrCoder and others added 2 commits July 25, 2025 07:52
@MrCoder @claude
Convert mermaid-zenuml README from symlink to regular file
1c269e0 
Changed packages/mermaid-zenuml/README.md from a symbolic link pointing to ../mermaid/src/docs/syntax/zenuml.md to a standalone README file with comprehensive documentation for the @mermaid-js/mermaid-zenuml package.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@MrCoder
chore: Upgrade @zenuml/core to version 3.35.2
da539c1
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 724197c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@mermaid-js/mermaid-zenuml Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Jul 27, 2025 •
edited
Loading

✅ Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 724197c
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/68860cd4ffda990008a02029
😎 Deploy Preview https://deploy-preview-6798--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Jul 27, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 27, 2025 •
edited
Loading

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@6798

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@6798

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6798

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6798

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6798

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@6798

commit: 724197c

@codecov Codecov
Copy link

codecov bot commented Jul 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.71%. Comparing base (1ceeca1) to head (724197c).
⚠️ Report is 12 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6798   +/-   ##
=======================================
  Coverage     3.70%   3.71%           
=======================================
  Files          454     455    +1     
  Lines        44739   44740    +1     
  Branches       707     708    +1     
=======================================
+ Hits          1659    1660    +1     
  Misses       43080   43080
Flag Coverage Δ
unit 3.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid-zenuml/src/zenuml.d.ts 100.00% <100.00%> (ø)
packages/mermaid-zenuml/src/zenumlRenderer.ts 0.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@autofix-ci autofix.ci
Copy link
Contributor

autofix-ci bot commented Jul 27, 2025

Hi! I'm autofix logoautofix.ci, a bot that automatically fixes trivial issues such as code formatting in pull requests.

I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:

  1. Allow edits by maintainers for your pull request, and then re-trigger CI (for example by pushing a new commit).
  2. Manually fix the issues identified for your pull request (see the GitHub Actions output for details on what I would like to change).

@argos-ci Argos CI
Copy link

argos-ci bot commented Jul 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Jul 27, 2025, 11:35 AM

@shubhamparikh2704 shubhamparikh2704 self-requested a review July 29, 2025 09:40
@shubhamparikh2704 shubhamparikh2704 added this pull request to the merge queue Jul 29, 2025
Merged via the queue into mermaid-js:develop with commit 435790f Jul 29, 2025
23 checks passed
This was referenced Aug 19, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamparikh2704 shubhamparikh2704 shubhamparikh2704 approved these changes

Assignees
No one assigned
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZenUML Rendering is broken
2 participants
@MrCoder @shubhamparikh2704