6750: Change MindmapDB to class based architecture #6751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a9a0a9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6751 +/- ##
==========================================
- Coverage 3.85% 3.70% -0.15%
==========================================
Files 454 454
Lines 44761 44722 -39
Branches 707 707
==========================================
- Hits 1725 1658 -67
- Misses 43036 43064 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sidharthv96
approved these changes
Jul 14, 2025
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
sidharthv96
reviewed
Jul 14, 2025
shubhamparikh2704
approved these changes
Jul 15, 2025
sidharthv96
requested changes
Jul 15, 2025
…//github.com/mermaid-js/mermaid into 6750-convert-mindmap-to-class-based-approach
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Refactors the existing Mind map implementation from a functional approach to a class-based architecture to improve code organization, maintainability, and extensibility.
Return a new DB object when diagramObject.db is called.
Introduces new MindmapDB class to encapsulate database operations and state
Migrates existing functions to class methods
Resolves #6750
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.