Skip to content

Conversation

darshanr0107
Copy link
Contributor

@darshanr0107 darshanr0107 commented Jul 14, 2025

📑 Summary

This PR fixes a Safari-specific rendering issue in sequence diagrams where the diagram title overlaps or collides with the top border of the box.

Resolves #6619

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Jul 14, 2025

🦋 Changeset detected

Latest commit: 3e3ae08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mermaid Patch
@mermaid-js/examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jul 14, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 3e3ae08
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/6874c429d7996a000846216c
😎 Deploy Preview https://deploy-preview-6747--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

pkg-pr-new bot commented Jul 14, 2025

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@6747

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@6747

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6747

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6747

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6747

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@6747

commit: 3e3ae08

Copy link

codecov bot commented Jul 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 3.85%. Comparing base (55527e7) to head (3e3ae08).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/sequence/svgDraw.js 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6747   +/-   ##
=======================================
  Coverage     3.85%   3.85%           
=======================================
  Files          455     455           
  Lines        44772   44772           
  Branches       707     707           
=======================================
  Hits          1725    1725           
  Misses       43047   43047           
Flag Coverage Δ
unit 3.85% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/sequence/svgDraw.js 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

argos-ci bot commented Jul 14, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 changed Jul 14, 2025, 9:05 AM

@shubhamparikh2704 shubhamparikh2704 added this pull request to the merge queue Jul 14, 2025
Merged via the queue into develop with commit f76e27d Jul 14, 2025
25 checks passed
@shubhamparikh2704 shubhamparikh2704 deleted the 6619-sequence-title-box-safari branch July 14, 2025 09:25
@github-actions github-actions bot mentioned this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sequence Diagram]title collides with box top border - safari
2 participants