Skip to content

Updated code to use class based approach for treemap #6738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 15, 2025
Merged

Updated code to use class based approach for treemap #6738

merged 16 commits into from
Jul 15, 2025

Conversation

shubhamparikh2704
Copy link
Member

@shubhamparikh2704 shubhamparikh2704 commented Jul 10, 2025 •
edited
Loading

📑 Summary

This pull request refactors the TreeMapDB implementation in the mermaid package, transitioning from a static object-based database to a class-based structure.

Resolves #6692

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 77e2703

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mermaid Patch
@mermaid-js/examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Jul 10, 2025 •
edited
Loading

✅ Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 77e2703
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/6876456b970ad50008633e40
😎 Deploy Preview https://deploy-preview-6738--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 10, 2025 •
edited
Loading

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@6738

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@6738

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6738

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6738

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6738

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@6738

commit: 77e2703

@codecov Codecov
Copy link

codecov bot commented Jul 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.23457% with 80 lines in your changes missing coverage. Please review.

Project coverage is 3.71%. Comparing base (1f3f8da) to head (77e2703).
Report is 26 commits behind head on develop.

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/treemap/db.ts 1.47% 67 Missing ⚠️
packages/mermaid/src/diagrams/treemap/parser.ts 0.00% 9 Missing ⚠️
packages/mermaid/src/diagrams/treemap/diagram.ts 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6738   +/-   ##
=======================================
  Coverage     3.70%   3.71%           
=======================================
  Files          453     454    +1     
  Lines        44703   44716   +13     
  Branches       707     707           
=======================================
+ Hits          1658    1659    +1     
- Misses       43045   43057   +12
Flag Coverage Δ
unit 3.71% <1.23%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/treemap/diagram.ts 8.33% <0.00%> (-1.67%) ⬇️
packages/mermaid/src/diagrams/treemap/parser.ts 0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/treemap/db.ts 1.33% <1.47%> (+1.33%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@argos-ci Argos CI
Copy link

argos-ci bot commented Jul 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Jul 15, 2025, 12:33 PM

@shubhamparikh2704 shubhamparikh2704 marked this pull request as ready for review July 10, 2025 15:19
@shubhamparikh2704 shubhamparikh2704 changed the title Updated code to use class based approach Updated code to use class based approach for treemap Jul 10, 2025
sidharthv96
sidharthv96 requested changes Jul 11, 2025
View reviewed changes
aloisklink
aloisklink reviewed Jul 11, 2025
View reviewed changes
sidharthv96
sidharthv96 requested changes Jul 11, 2025
View reviewed changes
saurabhg772244
saurabhg772244 reviewed Jul 14, 2025
View reviewed changes
@sidharthv96 sidharthv96 added this pull request to the merge queue Jul 15, 2025
Merged via the queue into develop with commit 9e2cd1a Jul 15, 2025
25 checks passed
@sidharthv96 sidharthv96 deleted the treemap-diagram-to-use-the-new-class-based-approach branch July 15, 2025 14:56
@github-actions github-actions bot mentioned this pull request Jul 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthv96 sidharthv96 sidharthv96 approved these changes

@aloisklink aloisklink Awaiting requested review from aloisklink

+1 more reviewer

@saurabhg772244 saurabhg772244 saurabhg772244 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Sponsored by MermaidChart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update treemap diagram to use the new class-based approach in the DB
4 participants
@shubhamparikh2704 @sidharthv96 @aloisklink @saurabhg772244