Skip to content

6730: Fix excluded dates ignored in YYYY-MM-DD HH:mm:ss date format in gantt diagram #6734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 8, 2025
Merged

6730: Fix excluded dates ignored in YYYY-MM-DD HH:mm:ss date format in gantt diagram #6734

merged 7 commits into from
Aug 8, 2025

Conversation

darshanr0107
Copy link
Contributor

@darshanr0107 darshanr0107 commented Jul 9, 2025 •
edited
Loading

📑 Summary

When using a Gantt diagram with dateFormat: 'YYYY-MM-DD HH:mm:ss', the excludes dates (like weekends or specific days) were not being correctly matched. This PR fixes the issue.

Resolves #6730

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Before

Before

After
image

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c847817

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mermaid Patch
@mermaid-js/examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Jul 9, 2025 •
edited
Loading

✅ Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit c847817
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/6877942d50dea000083422a1
😎 Deploy Preview https://deploy-preview-6734--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 9, 2025 •
edited
Loading

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@6734

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@6734

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6734

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6734

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6734

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@6734

commit: c847817

@codecov Codecov
Copy link

codecov bot commented Jul 9, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.71%. Comparing base (5b241bb) to head (c847817).
⚠️ Report is 121 commits behind head on develop.

Files with missing lines Patch % Lines
...ckages/mermaid/src/diagrams/gantt/ganttRenderer.js 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6734   +/-   ##
=======================================
  Coverage     3.70%   3.71%           
=======================================
  Files          454     453    -1     
  Lines        44724   44708   -16     
  Branches       707     708    +1     
=======================================
+ Hits          1659    1661    +2     
+ Misses       43065   43047   -18
Flag Coverage Δ
unit 3.71% <57.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/gantt/ganttDb.js 76.47% <100.00%> (+0.06%) ⬆️
...ckages/mermaid/src/diagrams/gantt/ganttRenderer.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@argos-ci Argos CI
Copy link

argos-ci bot commented Jul 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 3 added Jul 16, 2025, 12:17 PM

sidharthv96
sidharthv96 requested changes Jul 9, 2025
View reviewed changes
@darshanr0107 darshanr0107 requested a review from sidharthv96 July 10, 2025 11:05
sidharthv96
sidharthv96 requested changes Jul 15, 2025
View reviewed changes
@darshanr0107 @Mermaid-Chart
fix: update changeset
1176d30 
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
@darshanr0107 darshanr0107 requested a review from sidharthv96 July 16, 2025 07:42
knsv
knsv approved these changes Aug 8, 2025
View reviewed changes
Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, all comments have been resolved

@knsv knsv added this pull request to the merge queue Aug 8, 2025
Merged via the queue into develop with commit c4eb526 Aug 8, 2025
25 checks passed
@knsv knsv deleted the 6730-gantt-excludes-datetime-format branch August 8, 2025 09:44
This was referenced Aug 19, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knsv knsv knsv approved these changes

@ashishjain0512 ashishjain0512 Awaiting requested review from ashishjain0512

@aloisklink aloisklink Awaiting requested review from aloisklink

@shubhamparikh2704 shubhamparikh2704 Awaiting requested review from shubhamparikh2704

@sidharthv96 sidharthv96 Awaiting requested review from sidharthv96

Assignees
No one assigned
Labels
Graph: Gantt Sponsored by MermaidChart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dates in excludes are ignored in Gantt diagrams when dateFormat is 'YYYY-MM-DD HH:mm:ss'
4 participants
@darshanr0107 @knsv @sidharthv96 @shubhamparikh2704