fix: update leftMargin value #6715

Syn3ugar · 2025-07-04T04:04:46Z

📑 Summary

Updated the value of leftMargin.

Resolves #

📏 Design Decisions

LeftMargin should be taken from the timeline field of conf, not directly from conf.

📋 Tasks

Make sure you

📖 have read the contribution guidelines
💻 have added necessary unit/e2e tests.
📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

changeset-bot · 2025-07-04T04:04:49Z

🦋 Changeset detected

Latest commit: 637680d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
mermaid	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify · 2025-07-04T04:04:51Z

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	`637680d`
🔍 Latest deploy log	https://app.netlify.com/projects/mermaid-js/deploys/686f95d9c4180100088f5f15
😎 Deploy Preview	https://deploy-preview-6715--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

pkg-pr-new · 2025-07-04T04:06:04Z

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@6715

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@6715

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6715

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6715

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6715

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@6715

commit: 637680d

codecov · 2025-07-04T04:07:46Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 3.85%. Comparing base (91f141f) to head (637680d).
Report is 76 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../mermaid/src/diagrams/timeline/timelineRenderer.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #6715      +/-   ##
==========================================
+ Coverage     3.82%   3.85%   +0.02%     
==========================================
  Files          430     455      +25     
  Lines        44479   44772     +293     
  Branches       683     707      +24     
==========================================
+ Hits          1701    1725      +24     
- Misses       42778   43047     +269

Flag	Coverage Δ
unit	`3.85% <0.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../mermaid/src/diagrams/timeline/timelineRenderer.ts	`0.41% <0.00%> (ø)`

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

argos-ci · 2025-07-04T04:13:35Z

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	⚠️ Changes detected (Review)	4 changed	Jul 10, 2025, 10:38 AM

aloisklink

Hi @Syn3ugar! Thanks for your contribution!

It looks great to me.

I've made an update to the commit (mainly to add a changeset for the changelog).

Before merging, it looks like the author of the commit is we**** <we****@ba****.com> (I've censored the details here, but anybody can see them in https://github.com/mermaid-js/mermaid/commit/ab3370425c6d55628e36e748b9a9724d6b625088.patch), and this email address is not associated with the @Syn3ugar GitHub account.

Is this okay? You may want to change the email or add it to your GitHub account so you get credit once it's merged.

Syn3ugar · 2025-07-10T08:05:39Z

Hi @Syn3ugar! Thanks for your contribution!

It looks great to me.

I've made an update to the commit (mainly to add a changeset for the changelog).

Before merging, it looks like the author of the commit is we**** <we****@ba****.com> (I've censored the details here, but anybody can see them in https://github.com/mermaid-js/mermaid/commit/ab3370425c6d55628e36e748b9a9724d6b625088.patch), and this email address is not associated with the @Syn3ugar GitHub account.

Is this okay? You may want to change the email or add it to your GitHub account so you get credit once it's merged.

@aloisklink I am honored that this submission has been helpful to you. I apologize for using the wrong corporate email to submit this code. To avoid any further impact, could you please help me change it to my personal email address 1029359941@qq.com Thank you again for your recognition!

The `timeline.leftMargin` value in the docs/schema was not being correctly loaded for timeline diagrams.

aloisklink

Wonderful!

And no worries! Many people accidentally use the wrong email when making their git commit!

And FYI, if you do ever need to update a commit by yourself (or change the author just for one commit), you can do it like git commit --amend --author 'My Name <my-email@email.example>'

mermaid-bot · 2025-07-10T10:50:14Z

@Syn3ugar, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Syn3ugar · 2025-07-10T11:24:54Z

Wonderful!

And no worries! Many people accidentally use the wrong email when making their git commit!

And FYI, if you do ever need to update a commit by yourself (or change the author just for one commit), you can do it like git commit --amend --author 'My Name <my-email@email.example>'

Hope this little tip can be used for PR next time, sincerely appreciate!

github-actions bot added the Type: Enhancement New feature or request label Jul 4, 2025

shubhamparikh2704 self-assigned this Jul 8, 2025

shubhamparikh2704 requested review from aloisklink and shubhamparikh2704 July 8, 2025 07:29

aloisklink force-pushed the feature/timelineRenderer-conf branch from f603698 to ab33704 Compare July 10, 2025 06:57

aloisklink reviewed Jul 10, 2025

View reviewed changes

fix(timeline): load leftMargin from config

637680d

The `timeline.leftMargin` value in the docs/schema was not being correctly loaded for timeline diagrams.

aloisklink force-pushed the feature/timelineRenderer-conf branch from ab33704 to 637680d Compare July 10, 2025 10:28

aloisklink approved these changes Jul 10, 2025

View reviewed changes

aloisklink enabled auto-merge July 10, 2025 10:31

aloisklink added Graph: Timeline fix and removed Type: Enhancement New feature or request labels Jul 10, 2025

aloisklink added this pull request to the merge queue Jul 10, 2025

Merged via the queue into mermaid-js:develop with commit fad6676 Jul 10, 2025
22 of 24 checks passed

github-actions bot mentioned this pull request Jul 16, 2025

Version Packages #6762

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: update leftMargin value #6715

fix: update leftMargin value #6715

Uh oh!

Syn3ugar commented Jul 4, 2025

Uh oh!

changeset-bot bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

netlify bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

argos-ci bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

aloisklink left a comment

Uh oh!

Syn3ugar commented Jul 10, 2025 •

edited

Loading

Uh oh!

aloisklink left a comment

Uh oh!

Uh oh!

mermaid-bot bot commented Jul 10, 2025

Uh oh!

Syn3ugar commented Jul 10, 2025

Uh oh!

Uh oh!

Uh oh!

fix: update leftMargin value #6715

fix: update leftMargin value #6715

Uh oh!

Conversation

Syn3ugar commented Jul 4, 2025

📑 Summary

📏 Design Decisions

📋 Tasks

Uh oh!

changeset-bot bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

netlify bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for mermaid-js ready!

Uh oh!

pkg-pr-new bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

argos-ci bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aloisklink left a comment

Choose a reason for hiding this comment

Uh oh!

Syn3ugar commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aloisklink left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mermaid-bot bot commented Jul 10, 2025

Uh oh!

Syn3ugar commented Jul 10, 2025

Uh oh!

Uh oh!

changeset-bot bot commented Jul 4, 2025 •

edited

Loading

netlify bot commented Jul 4, 2025 •

edited

Loading

pkg-pr-new bot commented Jul 4, 2025 •

edited

Loading

codecov bot commented Jul 4, 2025 •

edited

Loading

argos-ci bot commented Jul 4, 2025 •

edited

Loading

Syn3ugar commented Jul 10, 2025 •

edited

Loading