Skip to content

Conversation

darshanr0107
Copy link
Contributor

@darshanr0107 darshanr0107 commented Jun 27, 2025

📑 Summary

This PR fixes an issue where the date format in gantt charts was not applied correctly. The chart was showing the full date (year, month, and day) even when only the day was expected.
Resolves #6649

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Before

image

After

image

Copy link

changeset-bot bot commented Jun 27, 2025

🦋 Changeset detected

Latest commit: 5cafe24

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mermaid Patch
@mermaid-js/examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jun 27, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 5cafe24
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/6877943b9a032f00081d4a16
😎 Deploy Preview https://deploy-preview-6693--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

pkg-pr-new bot commented Jun 27, 2025

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@6693

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@6693

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6693

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6693

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6693

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@6693

commit: 5cafe24

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.70%. Comparing base (5b241bb) to head (5cafe24).
⚠️ Report is 151 commits behind head on develop.

Files with missing lines Patch % Lines
...ckages/mermaid/src/diagrams/gantt/ganttRenderer.js 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6693   +/-   ##
=======================================
  Coverage     3.70%   3.70%           
=======================================
  Files          454     453    -1     
  Lines        44724   44723    -1     
  Branches       707     707           
=======================================
  Hits          1659    1659           
+ Misses       43065   43064    -1     
Flag Coverage Δ
unit 3.70% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ckages/mermaid/src/diagrams/gantt/ganttRenderer.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

argos-ci bot commented Jun 27, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 added Jul 16, 2025, 12:21 PM

on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
@darshanr0107 darshanr0107 requested a review from sidharthv96 July 16, 2025 07:51
Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments have been fixed. Approving. I have been reviewing multiple PRs and you are getting a good habit of adding visual tests. Keep that up, you can even add more of them. :)

@knsv knsv added this pull request to the merge queue Aug 8, 2025
Merged via the queue into develop with commit aa5d443 Aug 8, 2025
25 checks passed
@knsv knsv deleted the 6649-gantt-chart-dateformat branch August 8, 2025 10:21
This was referenced Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gantt chart dateFormat doesn't work as expected
4 participants