Skip to content

Conversation

darshanr0107
Copy link
Contributor

@darshanr0107 darshanr0107 commented Jun 24, 2025

📑 Summary

This PR addresses an issue where edge label in the state diagram was not positioned correctly relative to the edge.
Resolves #6576

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Before

image

After

image

Copy link

changeset-bot bot commented Jun 24, 2025

🦋 Changeset detected

Latest commit: 356da0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mermaid Patch
@mermaid-js/examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jun 24, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 356da0b
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/6895cb010156d10008030125
😎 Deploy Preview https://deploy-preview-6683--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

pkg-pr-new bot commented Jun 24, 2025

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@6683

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@6683

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6683

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6683

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6683

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@6683

commit: 356da0b

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

❌ Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.70%. Comparing base (c4eb526) to head (356da0b).
⚠️ Report is 40 commits behind head on develop.

Files with missing lines Patch % Lines
packages/mermaid/src/utils.ts 25.00% 6 Missing ⚠️
...aid/src/rendering-util/rendering-elements/edges.js 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6683   +/-   ##
=======================================
  Coverage     3.70%   3.70%           
=======================================
  Files          455     455           
  Lines        44862   44862           
  Branches       709     709           
=======================================
+ Hits          1662    1664    +2     
+ Misses       43200   43198    -2     
Flag Coverage Δ
unit 3.70% <15.38%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...aid/src/rendering-util/rendering-elements/edges.js 0.00% <0.00%> (ø)
packages/mermaid/src/utils.ts 18.18% <25.00%> (+0.09%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

argos-ci bot commented Jun 24, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 6 changed, 3 added Aug 8, 2025, 10:14 AM

Copy link
Member

@sidharthv96 sidharthv96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need visual tests for this

Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. All comments have been resolved/answered.

@knsv knsv added this pull request to the merge queue Aug 8, 2025
Merged via the queue into develop with commit 3d31982 Aug 8, 2025
25 checks passed
@knsv knsv deleted the 6576-state-diagram-label-position branch August 8, 2025 10:36
This was referenced Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buggy rendering differences between live and playground
4 participants