6584: prevent pie chart crash on zero or negative values #6651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0823e08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
added 2 commits
June 12, 2025 19:18
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6651 +/- ##
=======================================
Coverage 3.70% 3.71%
=======================================
Files 454 453 -1
Lines 44724 44715 -9
Branches 707 707
=======================================
Hits 1659 1659
+ Misses 43065 43056 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
shubhamparikh2704
requested changes
Jun 17, 2025
sidharthv96
requested changes
Jun 21, 2025
sidharthv96
requested changes
Jul 15, 2025
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
knsv
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
This PR adds validation to handle negative values in pie charts:
Prevents parser crashes caused by negative values by introducing validation during parsing.
Provides clearer error messaging to guide users when invalid input is detected.
Resolves #6584
📏 Design Decisions
Validation moved to the AST level:
Instead of rejecting values in the grammar, the parser accepts all numbers and performs validation during AST traversal. This allows more informative and user-friendly error messages.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Screenshots
Before
After
