chore: return internal endpoint (cluster ip) instead of external (host machine) in GetEndpointForPort #770
Conversation
…t machine) in GetEndpointForPort Signed-off-by: Nikita B <n2h9z4@gmail.com>
There was a problem hiding this comment.
Summary of Changes
Hello @n2h9, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a critical internal connectivity issue within the Meshery environment. By modifying the GetEndpointForPort function, it ensures that internal components correctly retrieve and utilize the Meshery broker's cluster IP, rather than an inaccessible external address. This change is fundamental for enabling seamless communication between services deployed within the Meshery pod.
Highlights
- Endpoint Resolution Fix: The
GetEndpointForPortfunction has been updated to return the internal cluster IP (endpoint.Internal) of the Meshery broker service. Previously, it was returning the external endpoint (endpoint.External), which was inaccessible from within the Meshery pod. - Internal Connectivity Improvement: This change directly addresses a connectivity issue, ensuring that services running inside the Meshery pod can correctly access the Meshery broker via its internal cluster IP, enabling proper communication and functionality.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The PR changes the endpoint retrieval to use the internal cluster IP for in-pod communication, which fixes the described connectivity issue. The review includes a suggestion to make the implementation more robust by adding a check for a valid internal endpoint address to prevent silent failures and improve debuggability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: n2h9 <13541181+n2h9@users.noreply.github.com>
…t machine) in GetEndpointForPort: add custom error ErrGetControllerEndpointForPortCode Signed-off-by: Nikita B <n2h9z4@gmail.com>
Description
Current version of GetEndpointForPort returns external endpoint which is :, which is not accessible within the meshery pod.
The correct approach is to use meshery-broker service cluster ip, which is available from
endpoint.Internalhere are screenshots with working buttons:
I searched, looks like this connectivity api is the only place of usage, so we can update in meshkit.
Signed commits