Revert "Merge pull request #15568 from n2h9/chore-fix-connection-pers… #15577
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @n2h9, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request performs a full revert of PR #15568, which aimed to modify connection persistence logic for duplicate Kubernetes configurations. The revert is necessary because the original changes introduced integration test failures, specifically related to an "already exists" error when saving Kubernetes contexts. By reverting, the PR restores the previous, stable behavior of the connection persistence mechanism.
Highlights
- Revert of Prior Changes: Fully reverts the changes introduced in pull request #15568, which had caused integration test failures.
- Error Handling Simplification: Removes the custom ErrConnectionAlreadyExist error and its associated logic, including its definition and specific handling in connection persistence.
- Restored Connection Logic: Reinstates the original behavior for saving Kubernetes contexts, no longer attempting to wrap or specifically handle existing connection errors.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that was causing integration tests to fail. The revert itself is correct and removes the problematic logic. However, the code being restored has a flaw: it silently ignores updates to existing connections, which could lead to data inconsistencies. I've provided a review comment with a suggested fix to properly handle updates for existing connections. This should address the underlying issue the original PR was trying to solve, while also keeping the tests passing.
| if err := tx.First(&existingConnection, "id = ?", connection.ID).Error; err == nil { | ||
| return ErrConnectionAlreadyExist | ||
| return err | ||
| } |
There was a problem hiding this comment.
While this revert fixes the integration test failure, the restored logic has a potential issue. If a connection with the same ID already exists, this function returns successfully without updating the record in the database. This means any changes to the connection's properties (like its metadata) will be silently ignored, leading to stale data.
To ensure data consistency, the function should update the existing record instead of just returning. This would also likely address the underlying issue that the original (now reverted) PR was trying to solve.
I suggest modifying the logic to perform an update when a connection is found.
if err := tx.First(&existingConnection, "id = ?", connection.ID).Error; err == nil {
// The connection already exists, so we update it.
// Preserve the creation timestamp to avoid it being overwritten.
connection.CreatedAt = existingConnection.CreatedAt
return tx.Save(connection).Error
} else if !errors.Is(err, gorm.ErrRecordNotFound) {
// An actual error occurred during the lookup.
return err
}There was a problem hiding this comment.
Thank you gemi 🙇♀️
I am reverting to previous state and then think how to handle this case properly ✅
|
|
|
Commit SHA: END-TO-END TESTS
📦 Test Result Summary
⌛ Duration: 6 minutes and 4 seconds Overall Result: 👍 All tests passed. [Show/Hide] Test Result Details
|
…ister-logic-on-duplicate-k8sconfig"
This reverts commit 9412578, reversing changes made to dd6ec7d.
Notes for Reviewers
because pr #15568 fails integration test.
here logs from set up step
revert first, figure out later ✅
Signed commits