Revert some commits that broke PCH on MSVC, and others #10976
Conversation
…ir objects" This reverts commit c94c492. This broke propagated deps as well as PCH in MSVC, and has not been fixed in time for the final release of 0.64.0, so it needs to be reverted and then brought back later. Fixes mesonbuild#10745 Fixes mesonbuild#10975
This reverts commit d285be7. This is part of mesonbuild#10628 and needs to be reverted, as it breaks other things. See mesonbuild#10628 (comment)
This reverts commit bdc6f24. This is part of mesonbuild#10628 and needs to be reverted, as it breaks other things. See mesonbuild#10628 (comment)
Codecov Report
@@ Coverage Diff @@
## master #10976 +/- ##
==========================================
- Coverage 68.31% 65.73% -2.59%
==========================================
Files 412 207 -205
Lines 87768 44878 -42890
Branches 19385 9271 -10114
==========================================
- Hits 59962 29502 -30460
+ Misses 23315 13030 -10285
+ Partials 4491 2346 -2145
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
5ce8bf3 to
21f86fa
Compare
|
Merging this so fast without someone else reviewing it is not really cool. At the very least this MR should have added the regression test from #10962 both to ensure that this fixes the issue and that it won't slip by the next time this fix is attempted. I have rebased that MR to rerun the tests. |
|
I figured since it's a straight revert there isn't much to review. :/ And I pinged @anarazel to rebase the PR with the test... It is extremely on my radar and won't be forgotten, it just depends on a revert before it passes CI... |
This reverts commit c94c492.
This broke propagated deps as well as PCH in MSVC, and has not been fixed in time for the final release of 0.64.0, so it needs to be reverted and then brought back later.
Fixes #10745
Fixes #10975
Also reverts the following commits that were broken and fixed by c94c492 and therefore need to be reverted by it:
This reverts commit d285be7.
ranlib -c $outwhen using the apple ar"This reverts commit bdc6f24.