-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
add test for global variable #10587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test for global variable #10587
Conversation
I would put this in "common/5 linkstatic" |
Codecov Report
@@ Coverage Diff @@
## master #10587 +/- ##
===========================================
- Coverage 68.83% 50.31% -18.52%
===========================================
Files 406 203 -203
Lines 88038 44018 -44020
Branches 19550 9757 -9793
===========================================
- Hits 60598 22149 -38449
+ Misses 22868 19866 -3002
+ Partials 4572 2003 -2569
Continue to review full report at Codecov.
|
This comment was marked as outdated.
This comment was marked as outdated.
artok on IRC reported that this test does indeed fail on OSX they also found out that it stops failing if you install llvm from homebrew and replace ar with llvm-ar |
just removing llvm is enough to make it fail, also on macos-11 |
source: https://lists.gnu.org/archive/html/libtool/2002-07/msg00025.html also add a CI config to run test without llvm from homebrew
Which is old and annoying and doesn't expose global symbols by default, so we need a work around. see: mesonbuild#10587 see: https://lists.gnu.org/archive/html/libtool/2002-07/msg00025.html
Which is old and annoying and doesn't expose global symbols by default, so we need a work around. see: #10587 see: https://lists.gnu.org/archive/html/libtool/2002-07/msg00025.html
This test case was included in #10628 alongside the actual fix. |
Which is old and annoying and doesn't expose global symbols by default, so we need a work around. see: #10587 see: https://lists.gnu.org/archive/html/libtool/2002-07/msg00025.html
source: https://lists.gnu.org/archive/html/libtool/2002-07/msg00025.html