Skip to content

Conversation

ailin-nemui
Copy link
Contributor

@ailin-nemui ailin-nemui requested a review from jpakkane as a code owner July 11, 2022 13:46
@eli-schwartz
Copy link
Member

I would put this in "common/5 linkstatic"

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #10587 (0c641d4) into master (ec388fe) will decrease coverage by 18.51%.
The diff coverage is n/a.

❗ Current head 0c641d4 differs from pull request most recent head 8a680e2. Consider uploading reports for the commit 8a680e2 to get more accurate results

@@             Coverage Diff             @@
##           master   #10587       +/-   ##
===========================================
- Coverage   68.83%   50.31%   -18.52%     
===========================================
  Files         406      203      -203     
  Lines       88038    44018    -44020     
  Branches    19550     9757     -9793     
===========================================
- Hits        60598    22149    -38449     
+ Misses      22868    19866     -3002     
+ Partials     4572     2003     -2569     
Impacted Files Coverage Δ
modules/qt5.py 0.00% <0.00%> (-100.00%) ⬇️
modules/modtest.py 0.00% <0.00%> (-100.00%) ⬇️
scripts/run_tool.py 0.00% <0.00%> (-100.00%) ⬇️
scripts/msgfmthelper.py 0.00% <0.00%> (-100.00%) ⬇️
modules/keyval.py 0.00% <0.00%> (-95.24%) ⬇️
scripts/clangtidy.py 0.00% <0.00%> (-93.34%) ⬇️
scripts/vcstagger.py 0.00% <0.00%> (-91.67%) ⬇️
modules/unstable_icestorm.py 0.00% <0.00%> (-91.67%) ⬇️
modules/sourceset.py 0.00% <0.00%> (-90.54%) ⬇️
scripts/depscan.py 0.00% <0.00%> (-83.92%) ⬇️
... and 320 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec388fe...8a680e2. Read the comment docs.

@ailin-nemui

This comment was marked as outdated.

@ailin-nemui ailin-nemui reopened this Jul 24, 2022
@ailin-nemui
Copy link
Contributor Author

ailin-nemui commented Jul 24, 2022

artok on IRC reported that this test does indeed fail on OSX

they also found out that it stops failing if you install llvm from homebrew and replace ar with llvm-ar

@ailin-nemui
Copy link
Contributor Author

ailin-nemui commented Jul 24, 2022

I added a CI test using macos-12 and also not installing llvm, and it fails

just removing llvm is enough to make it fail, also on macos-11

@dcbaker dcbaker added bug OS:macos Issues specific to Apple Operating Systems like MacOS and iOS labels Jul 24, 2022
source: https://lists.gnu.org/archive/html/libtool/2002-07/msg00025.html

also add a CI config to run test without llvm from homebrew
dcbaker added a commit to dcbaker/meson that referenced this pull request Jul 25, 2022
Which is old and annoying and doesn't expose global symbols by default,
so we need a work around.

see: mesonbuild#10587
see: https://lists.gnu.org/archive/html/libtool/2002-07/msg00025.html
dcbaker added a commit that referenced this pull request Jul 25, 2022
Which is old and annoying and doesn't expose global symbols by default,
so we need a work around.

see: #10587
see: https://lists.gnu.org/archive/html/libtool/2002-07/msg00025.html
@eli-schwartz
Copy link
Member

This test case was included in #10628 alongside the actual fix.

nirbheek pushed a commit that referenced this pull request Aug 8, 2022
Which is old and annoying and doesn't expose global symbols by default,
so we need a work around.

see: #10587
see: https://lists.gnu.org/archive/html/libtool/2002-07/msg00025.html
@ailin-nemui ailin-nemui deleted the global-var-test branch September 2, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS:macos Issues specific to Apple Operating Systems like MacOS and iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants