Cleanup attrs errors #807
Merged
Cleanup attrs errors #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
reviewed
Oct 22, 2023
anmonteiro
approved these changes
Oct 22, 2023
5164647 to
aa0d30c
Compare
|
Thank you! |
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Oct 22, 2023
CHANGES: - Add TRMC (Tail Recursion Modulo Cons) support ([melange-re/melange#743](melange-re/melange#743)) - [playground]: Add `melange.dom` to bundle ([melange-re/melange#779](melange-re/melange#779)) - Fix `Sys.argv` runtime to match declared type ([melange-re/melange#791](melange-re/melange#791)) - Make `'a Js.t` abstract (again), fixing a regression when bringing back OCaml-style objects BuckleScript ([melange-re/melange#786](melange-re/melange#786)) - Don't issue "unused attribute" warning for well-formed `@@@mel.config` in interface files ([melange-re/melange#800](melange-re/melange#800)) - Stop showing `Js__.Js_internal` in types and error messages ([melange-re/melange#798](melange-re/melange#798)) - Fix printing of OCaml-style objects and uncurried application ([melange-re/melange#807](melange-re/melange#807))
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: - Add TRMC (Tail Recursion Modulo Cons) support ([melange-re/melange#743](melange-re/melange#743)) - [playground]: Add `melange.dom` to bundle ([melange-re/melange#779](melange-re/melange#779)) - Fix `Sys.argv` runtime to match declared type ([melange-re/melange#791](melange-re/melange#791)) - Make `'a Js.t` abstract (again), fixing a regression when bringing back OCaml-style objects BuckleScript ([melange-re/melange#786](melange-re/melange#786)) - Don't issue "unused attribute" warning for well-formed `@@@mel.config` in interface files ([melange-re/melange#800](melange-re/melange#800)) - Stop showing `Js__.Js_internal` in types and error messages ([melange-re/melange#798](melange-re/melange#798)) - Fix printing of OCaml-style objects and uncurried application ([melange-re/melange#807](melange-re/melange#807))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #747.
Fixes #806.
Companion PR: melange-re/melange-compiler-libs#30.
The first commit shows current behavior in
main. Second one shows the diff after picking the changes from that ^ compiler libs PR.