Skip to content

Conversation

jchavarri
Copy link
Member

This is the first part of melange-re/melange-re.github.io#115, will work on the 2nd part once this PR is merged.

  • Rename js_error_msg to js_warning_error_msg when producing objects from location reports
  • Include a new warning property for the object sent with successful builds
  • Add a test to exercise the last point

@jchavarri jchavarri merged commit 1cd8dde into main Oct 31, 2023
@jchavarri jchavarri deleted the playground/send-warnings-always branch October 31, 2023 07:53
@jchavarri jchavarri restored the playground/send-warnings-always branch October 31, 2023 07:53
@jchavarri jchavarri deleted the playground/send-warnings-always branch October 31, 2023 07:53
@jchavarri jchavarri restored the playground/send-warnings-always branch October 31, 2023 07:53
@jchavarri jchavarri deleted the playground/send-warnings-always branch October 31, 2023 07:53
@anmonteiro
Copy link
Member

Very cool! I think this still doesn't catch PPX alerts, or am I mistaken?

@jchavarri
Copy link
Member Author

You're right, I somehow missed that :) fix in #861.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants