use for_js, don't export OCaml id #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesnx
reviewed
Sep 4, 2023
ppx/ast_attributes.ml
Outdated
| let has_mel_for_js_payload (attrs : t) = | ||
| Ext_list.find_first attrs (fun { attr_name = { txt; loc }; _ } -> | ||
| warn_if_bs ~loc txt; | ||
| txt = "mel.for_js") |
There was a problem hiding this comment.
I think a mel.export might make more sense here?
There was a problem hiding this comment.
we chatted offline about reusing mel.as.
|
Thanks, will continue in #714 |
anmonteiro
added a commit
that referenced
this pull request
Sep 4, 2023
* use for_js, don't export OCaml id * add test to showcase consumption * use mel.as --------- Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
added a commit
that referenced
this pull request
Sep 5, 2023
* feat: allow exporting invalid OCaml identifiers in JS * setup * `.mli` support * add a reserved JS keyword in the test * use for_js, don't export OCaml id (#718) * use for_js, don't export OCaml id * add test to showcase consumption * use mel.as --------- Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * s/Ext_list.find_first/List.find_opt * add changelog entry --------- Co-authored-by: Javier Chávarri <javier.chavarri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.