fix: make Js.t abstract (again)
#786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3800d30 to
1a041b5
Compare
|
1b9691d fixes the tests for this change, but I'm not sure why |
jchavarri
reviewed
Oct 19, 2023
| @@ -5,14 +5,12 @@ Test `@mel.unwrap` in `@mel.obj` | |||
| > external func : | |||
| > param:string -> | |||
| > polyParam:([ \`Str of string | \`Int of int ][@mel.unwrap]) -> | |||
| > unit -> | |||
| > _ Js.t = "" | |||
There was a problem hiding this comment.
This looks like a regression. Shouldn't mel.obj return a 'a Js.t value?
There was a problem hiding this comment.
It's still a Js.t, but it gets around the weak type variable warning
fix: tests
not sure about this one. also seems to happen on 4.14
1b9691d to
6e96d04
Compare
This was referenced Oct 19, 2023
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Oct 22, 2023
CHANGES: - Add TRMC (Tail Recursion Modulo Cons) support ([melange-re/melange#743](melange-re/melange#743)) - [playground]: Add `melange.dom` to bundle ([melange-re/melange#779](melange-re/melange#779)) - Fix `Sys.argv` runtime to match declared type ([melange-re/melange#791](melange-re/melange#791)) - Make `'a Js.t` abstract (again), fixing a regression when bringing back OCaml-style objects BuckleScript ([melange-re/melange#786](melange-re/melange#786)) - Don't issue "unused attribute" warning for well-formed `@@@mel.config` in interface files ([melange-re/melange#800](melange-re/melange#800)) - Stop showing `Js__.Js_internal` in types and error messages ([melange-re/melange#798](melange-re/melange#798)) - Fix printing of OCaml-style objects and uncurried application ([melange-re/melange#807](melange-re/melange#807))
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: - Add TRMC (Tail Recursion Modulo Cons) support ([melange-re/melange#743](melange-re/melange#743)) - [playground]: Add `melange.dom` to bundle ([melange-re/melange#779](melange-re/melange#779)) - Fix `Sys.argv` runtime to match declared type ([melange-re/melange#791](melange-re/melange#791)) - Make `'a Js.t` abstract (again), fixing a regression when bringing back OCaml-style objects BuckleScript ([melange-re/melange#786](melange-re/melange#786)) - Don't issue "unused attribute" warning for well-formed `@@@mel.config` in interface files ([melange-re/melange#800](melange-re/melange#800)) - Stop showing `Js__.Js_internal` in types and error messages ([melange-re/melange#798](melange-re/melange#798)) - Fix printing of OCaml-style objects and uncurried application ([melange-re/melange#807](melange-re/melange#807))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there's a missing commit from rescript-lang/rescript#4967 that we must have forgotten to revert: rescript-lang/rescript@ee283b0
I'm going to do another pass over the full PR and make sure we're not missing anything else.
fixes #758