Skip to content

Conversation

jchavarri
Copy link
Member

not sure how this alert works, created a test to show it appears sometimes, but sometimes it does not.

Copy link
Member

@anmonteiro anmonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. probably good to see these inconsistencies fixed as we go about improving the FFI

@jchavarri
Copy link
Member Author

Opened #778 to track this.

@jchavarri jchavarri merged commit 482b2bb into main Oct 13, 2023
@jchavarri jchavarri deleted the test-redundant-alert-behavior branch October 13, 2023 13:48
jchavarri added a commit that referenced this pull request Oct 13, 2023
* main:
  playground: split test file into multiple ones (#759)
  test redundant alert behavior (#761)
  rename: {Bs_conditional_initial,Res_compmisc} to Initialization.{Global,Perfile} (#776)
  refactor: remove branches that are never created
  rename: bs_exception -> mel_exception
  refactor: move load_unit to Js_cmj_format (#774)
  refactor: only override load_cmi in the playground bundle (#773)
  refactor: use a single output_prefix function (#772)
  refactor: use a dedicated type for artifact extensions (#771)
  refactor: delete ext_fmt and ext_js_file_kind (#770)
  refactor: use a single file -> module_name function (#769)
  refactor: inline ext_char and valid_input_extension (#768)
  chore: clean up unnecessary functions in Ext_array (#767)
  chore(core lib): remove unused files (#765)
  chore: remove unused modules from Ext. (#766)
  chore: simplify `melange.dom` dune rules (#764)
  update opam sw version in makefile (#760)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants