playground: bring back cmijs hack #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
reviewed
Jul 3, 2023
|
@anmonteiro thanks for the improvement. Tested with (wip) playground and everything seems to work fine, and the tests are passing too, so I think we can merge this one. |
* main: Update CONTRIBUTING.md to include an installation step for melange.opam and a link to the Pull Request instructions (#651)
jchavarri
added a commit
that referenced
this pull request
Jul 6, 2023
* main: playground: bring back cmijs hack (#648)
jchavarri
added a commit
that referenced
this pull request
Jul 10, 2023
* main: (22 commits) playground: fix warning errors playground: add test for bad error msg playground: use js_of_ocaml library (#654) chore: update nix flakes (#652) playground: bring back cmijs hack (#648) Update CONTRIBUTING.md to include an installation step for melange.opam and a link to the Pull Request instructions (#651) playground: specify ppx dep (#646) playground: package + es6 + direct reason compilation (#632) feat: add `-rectypes` (#644) fix changelog fix: spurious warning 61 in externals test: show spurious warning 61 in externals test: show how to disable ppx alerts (#642) fix: disable warning 61 (`unboxable-type-in-prim-decl`) for deriving abstract externals test: show spurious warning on single field records with [@@deriving abstract] chore: format runtime / belt / node libraries (#640) chore: test on OCaml 5.1 (#639) chore: require dune 3.8, format, cleanup (#638) refactor: Don't use `(stdlib ...)` for the `Js.*` runtime (#637) chore: snapshot JS test files (#636) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change broke generation of the cmijs when
melange-playgroundis installed, because there are no cmjs in../jscomp/others/.belt.objs/melange/*.cm{i,j}.There is no clean way to fix it, as it's not possible to use
%{lib:melange:js...with globs like*.cm{i,j}:(glob_files %{lib:melange:belt}/melange/*.cm{i,j})the error is:(glob_files %{lib:melange:belt/melange/*.cm{i,j}})the error is:This PR brings back the original hack, which adds a single
cmias dep, and then usesfind,dirnameandxargsto build the cmijs.