feat: split string interpolation from unicode processing #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2024
5d782b8 to
0370004
Compare
also error on pattern matching unicode
anmonteiro
added a commit
that referenced
this pull request
Jan 29, 2024
* feat: split string interpolation from unicode processing
* fix: unit tests
* fix: blackbox tests
* refactor: unnest Utf8_string.Utf8_string
* refactor: delete some unused code
* chore: add PR to the relevant changelog entry
* string_itnerp: add interface
* fix: print uninterpreted-delimiters warning if `{j| .. |j}`
also error on pattern matching unicode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #863 #995.
Moving both
{js| .. |js}and{j| .. |j}from the PPX to the compiler core in #995 ended up causingunused variablewarnings when editing the sources.This change disentangles
{j|-based string interpolation (which just knows to concatenate multiple strings separated by interpolated variables) from{js| ..unicode processing and printing. It:{j| .., expands to multiple AST nodes with{js|strings{js| ..unicode strings and treats them as such.