Skip to content

Fix Total Hits being wrong when rankingScoreThreshold is used #5725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 16, 2025
Merged

Fix Total Hits being wrong when rankingScoreThreshold is used #5725

merged 6 commits into from
Jul 16, 2025

Conversation

Mubelotix
Copy link
Contributor

Pull Request

Related issue

Fixes #5274

What does this PR do?

This PR ensures the bucket_sort doesn't abort too early when using rankingScoreThreshold

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@Mubelotix Mubelotix added the no db change The database didn't change label Jul 1, 2025
@Mubelotix Mubelotix added this to the v1.16.0 milestone Jul 1, 2025
@Mubelotix Mubelotix marked this pull request as ready for review July 1, 2025 14:41
@Mubelotix Mubelotix requested a review from dureuill July 1, 2025 14:41
@Mubelotix Mubelotix added the impacts docs This issue involves changes in the Meilisearch's documentation label Jul 7, 2025
@guimachiavelli guimachiavelli mentioned this pull request Jul 14, 2025
Closed
1 task
dureuill
dureuill reviewed Jul 15, 2025
View reviewed changes
@Mubelotix @dureuill
Apply review suggestions
d6bd60d 
Co-Authored-By: Louis Dureuil <louis.dureuil@xinra.net>
@Mubelotix Mubelotix changed the base branch from main to release-v1.16.0 July 15, 2025 16:01
@Mubelotix Mubelotix requested a review from dureuill July 15, 2025 16:02
dureuill
dureuill approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dureuill dureuill added this pull request to the merge queue Jul 16, 2025
Merged via the queue into release-v1.16.0 with commit 8887cbd Jul 16, 2025
11 checks passed
@dureuill dureuill deleted the fix-threshold-overcounting-bug branch July 16, 2025 07:58
@curquiza curquiza mentioned this pull request Jul 18, 2025
Closed
@BrewTestBot BrewTestBot mentioned this pull request Aug 4, 2025
Merged
@meili-bot meili-bot added the v1.16.0 PRs/issues solved in v1.16.0 released on 2025-08-04 label Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dureuill dureuill dureuill approved these changes

Assignees
No one assigned
Labels
impacts docs This issue involves changes in the Meilisearch's documentation no db change The database didn't change v1.16.0 PRs/issues solved in v1.16.0 released on 2025-08-04
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

Total Hits is wrong when there is rankingScoreThreshold
3 participants
@Mubelotix @dureuill @meili-bot