Skip to content

Fix the environment variable name of the experimental limit batched tasks total size feature #5705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Fix the environment variable name of the experimental limit batched tasks total size feature #5705

merged 1 commit into from
Jun 25, 2025

Conversation

Kerollmops
Copy link
Member

Pull Request

Related issue

Fixes #5704

What does this PR do?

  • The PR change the name to be the right one...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Kerollmops Kerollmops added this to the v1.16.0 milestone Jun 24, 2025
@Kerollmops Kerollmops added the no db change The database didn't change label Jun 24, 2025
@Kerollmops Kerollmops requested a review from dureuill June 24, 2025 13:29
@dureuill
Copy link
Contributor

which variable name is the Cloud environment using right now?

@Kerollmops
Copy link
Member Author

@dureuill they are using the right one, the one I am switching to in this PR. That's how I found out 🤦‍♂️

dureuill
dureuill approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@dureuill dureuill left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good then, still we should make sure they don't have any of the wrong one laying around

@Kerollmops Kerollmops added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit 00bc86e Jun 25, 2025
16 checks passed
@Kerollmops Kerollmops deleted the fix-max-total-size-limit-env-var branch June 25, 2025 13:31
@BrewTestBot BrewTestBot mentioned this pull request Aug 4, 2025
Merged
@meili-bot meili-bot added the v1.16.0 PRs/issues solved in v1.16.0 released on 2025-08-04 label Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dureuill dureuill dureuill approved these changes

Assignees
No one assigned
Labels
no db change The database didn't change v1.16.0 PRs/issues solved in v1.16.0 released on 2025-08-04
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

The experimental limit batched tasks total size environment variable is not fulfilled
3 participants
@Kerollmops @dureuill @meili-bot