Skip to content

tests: Use Server::wait_task() instead of Index::wait_task() in search:: #5700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

tests: Use Server::wait_task() instead of Index::wait_task() in search:: #5700

merged 1 commit into from
Jun 23, 2025

Conversation

martin-g
Copy link
Contributor

Pull Request

Related issue

#4840

What does this PR do?

  • The code is mostly duplicated. Server::wait_task() has better handling for errors and more retries.

@martin-g
tests: Use Server::wait_task() instead of Index::wait_task() in search::
855fa55 
The code is mostly duplicated. Server::wait_task() has better handling for errors and more retries.

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g martin-g force-pushed the search-use-server-wait-task branch from abc81cb to 855fa55 Compare June 22, 2025 11:54
@martin-g martin-g mentioned this pull request Jun 22, 2025
Open
32 tasks
irevoire
irevoire approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good thanks

@irevoire irevoire added maintenance Issue about maintenance (CI, tests, refacto...) no db change The database didn't change labels Jun 23, 2025
@irevoire irevoire added this pull request to the merge queue Jun 23, 2025
@irevoire irevoire added this to the v1.16.0 milestone Jun 23, 2025
Merged via the queue into meilisearch:main with commit 748a327 Jun 23, 2025
14 of 16 checks passed
@martin-g martin-g deleted the search-use-server-wait-task branch July 10, 2025 11:44
@BrewTestBot BrewTestBot mentioned this pull request Aug 4, 2025
Merged
@meili-bot meili-bot added the v1.16.0 PRs/issues solved in v1.16.0 released on 2025-08-04 label Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irevoire irevoire irevoire approved these changes

Assignees
No one assigned
Labels
maintenance Issue about maintenance (CI, tests, refacto...) no db change The database didn't change v1.16.0 PRs/issues solved in v1.16.0 released on 2025-08-04
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@martin-g @irevoire @meili-bot