Skip to content

Fix chat settings dumpless upgrade #5761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025

Conversation

Kerollmops
Copy link
Member

Fix a bug when using the dumpless upgrade when chat settings were already present in the index. This bug was introduced in #5710, and I mislabeled the PR as no db change when, in reality, it was.

@Kerollmops Kerollmops added this to the v1.16.0 milestone Jul 17, 2025
@Kerollmops Kerollmops requested a review from irevoire July 17, 2025 13:30
@Kerollmops Kerollmops added the no db change The database didn't change label Jul 17, 2025
@Kerollmops Kerollmops changed the base branch from main to release-v1.16.0 July 17, 2025 13:30
@Kerollmops Kerollmops force-pushed the fix-chat-settings-dumpless-upgrade branch from 9e82dd2 to f1d92bf Compare July 17, 2025 13:36
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you perfect

@irevoire irevoire enabled auto-merge July 17, 2025 13:40
Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irevoire irevoire added this pull request to the merge queue Jul 17, 2025
Merged via the queue into release-v1.16.0 with commit 0312fb2 Jul 17, 2025
27 of 29 checks passed
@irevoire irevoire deleted the fix-chat-settings-dumpless-upgrade branch July 17, 2025 17:09
@meili-bot meili-bot added the v1.16.0 PRs/issues solved in v1.16.0 released on 2025-08-04 label Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no db change The database didn't change v1.16.0 PRs/issues solved in v1.16.0 released on 2025-08-04
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants