tests: Faster stats::mod IT tests #5611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManyTheFish
approved these changes
Jun 2, 2025
ManyTheFish
previously requested changes
Jun 2, 2025
There was a problem hiding this comment.
Hey @martin-g,
the code is not compiling 🤔
can you fix that?
irevoire
requested changes
Jun 2, 2025
|
|
Use shared server + unique indices Related-to: meilisearch#4840 Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Using a shared server will make this test fragile Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
auto-merge was automatically disabled
June 4, 2025 10:10
Head branch was pushed to by a user without write access
af68cd6 to
0557a4d
Compare
|
@ManyTheFish The build is green now. Could you please review again ? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
#4840
What does this PR do?