-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Decouple geo facet extraction from rest of document #5592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ManyTheFish
merged 10 commits into
meilisearch:main
from
nnethercott:extract-geo-facets-seperately
May 28, 2025
Merged
Decouple geo facet extraction from rest of document #5592
ManyTheFish
merged 10 commits into
meilisearch:main
from
nnethercott:extract-geo-facets-seperately
May 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManyTheFish
reviewed
May 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @nnethercott,
Nice PR, I wrote some change requests ,
thank you for contributing to Meilisearch!
Co-authored-by: Many the fish <many@meilisearch.com>
Co-authored-by: Many the fish <many@meilisearch.com>
ManyTheFish
approved these changes
May 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
thank you for the contribution
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #5440
What does this PR do?
extract_geo_document
for _geo facet extraction & removes that logic fromextract_document_facets
macro_rules!
macro to generateadd
anddel
facet functions, limiting code duplicationNote: Since each variant of the macro uses a &mut ref, we can't just define top level helpers to use throughout the match block. Ideally a factory function would be used in place of this macro but since closures have anonymous types we run into issues defining the signature of the factory, unless we wanna toss in
Box<dyn ...>
. I think the macro is a nice trade-off herePR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!