Skip to content

Rename batch creation complete #5588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2025
Merged

Rename batch creation complete #5588

merged 3 commits into from
May 22, 2025

Conversation

dureuill
Copy link
Contributor

@dureuill dureuill commented May 22, 2025 •
edited
Loading

  • Rename batchCreationComplete to batchStrategy
  • Adjust messages to fit the new name (and the messages are more descriptive 🎉)
  • Update snapshots

No db changes

  • as only the displayed batch object is modified, the database format doesn't change at all in this PR
  • the values of the stop reason change in this PR compared with v1.15.0-rc.{0-2}, but this is compatible in both directions

@dureuill dureuill added this to the v1.15.0 milestone May 22, 2025
@dureuill dureuill requested a review from irevoire May 22, 2025 10:39
@dureuill dureuill added the no db change The database didn't change label May 22, 2025
@dureuill dureuill mentioned this pull request May 22, 2025
Merged
@dureuill dureuill changed the title Rename batch stopped reason Rename batch creation complete May 22, 2025
irevoire
irevoire approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto, thank you! 🌵

@irevoire irevoire added this pull request to the merge queue May 22, 2025
@dureuill dureuill merged commit ee326a1 into release-v1.15.0 May 22, 2025
18 checks passed
@dureuill dureuill deleted the rename-batch-stopped-reason branch May 22, 2025 13:25
@meili-bot meili-bot added the v1.15.0 PRs/issues solved in v1.15.0 released on 2025-06-09 label Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irevoire irevoire irevoire approved these changes

Assignees
No one assigned
Labels
no db change The database didn't change v1.15.0 PRs/issues solved in v1.15.0 released on 2025-06-09
Projects
None yet
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dureuill @irevoire @meili-bot