Skip to content

Split unit test in tasks.rs #5424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2025

Conversation

shu-kitamura
Copy link
Contributor

Pull Request

Splits the tests for meilisearch search crate in a separate testfile.

Related issue

Partially solves #5116.

What does this PR do?

Splits the unit test in /routes/tasks.rs into a separate file /routes/tasks_test.rs in meilisearch crate

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @shu-kitamura,

I requested a small change,

thank you for your contribution

@ManyTheFish ManyTheFish added this to the v1.15.0 milestone Mar 19, 2025
Co-authored-by: Many the fish <many@meilisearch.com>
@shu-kitamura
Copy link
Contributor Author

shu-kitamura commented Mar 19, 2025

@ManyTheFish
Thank you for checking!!!

@ManyTheFish ManyTheFish added this pull request to the merge queue Mar 24, 2025
Merged via the queue into meilisearch:main with commit 5759afa Mar 24, 2025
11 checks passed
@shu-kitamura shu-kitamura deleted the split-tasks-test branch March 24, 2025 10:46
@meili-bot meili-bot added the v1.15.0 PRs/issues solved in v1.15.0 released on 2025-06-09 label Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.15.0 PRs/issues solved in v1.15.0 released on 2025-06-09
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants