Skip to content

Stop compacting the snapshot #5498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Stop compacting the snapshot #5498

merged 1 commit into from
Apr 15, 2025

Conversation

dureuill
Copy link
Contributor

@dureuill dureuill commented Apr 8, 2025

Pull Request

Related issue

Fixes TBD

What does this PR do?

  • No longer enable the compaction option when performing a snapshot

@dureuill dureuill added this to the v1.15.0 milestone Apr 8, 2025
@dureuill dureuill requested review from Kerollmops and irevoire April 8, 2025 12:55
@dureuill dureuill added the no db change The database didn't change label Apr 8, 2025
irevoire
irevoire approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me, I thought we were also going to stop compressing the snapshots but if it was not intended you can merge 👍

@dureuill
Copy link
Contributor Author

compaction was the most urgent matter. compression I'll do if I manage to smuggle the parameters

@dureuill dureuill added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 3a93f88 Apr 15, 2025
14 of 15 checks passed
@dureuill dureuill deleted the snapshot-no-compaction branch April 15, 2025 09:07
@meili-bot meili-bot added the v1.15.0 PRs/issues solved in v1.15.0 released on 2025-06-09 label Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irevoire irevoire irevoire approved these changes

@Kerollmops Kerollmops Awaiting requested review from Kerollmops

Assignees
No one assigned
Labels
no db change The database didn't change v1.15.0 PRs/issues solved in v1.15.0 released on 2025-06-09
Projects
None yet
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dureuill @irevoire @meili-bot