Skip to content

fix: Failed to collect Dubbo and Motan plugin metrics using Prometheus #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2023
Merged

fix: Failed to collect Dubbo and Motan plugin metrics using Prometheus #310

merged 1 commit into from
Feb 27, 2023

Conversation

oewang
Copy link
Contributor

@oewang oewang commented Feb 27, 2023

  • Change the label name service of the dubbo and motan plugins to interface.
  • Refactor code
  • Remove unnecessary unit tests

Closes #309

@oewang
fix: Failed to collect Dubbo and Motan plugin metrics using Prometheus
9778ede 
- Change the label name `service` of the dubbo and motan plugins to
`interface`.
- Refactor code
- Remove unnecessary unit tests

Closes megaease#309
@landyking landyking merged commit 54b9256 into megaease:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@observeralone observeralone observeralone approved these changes

@landyking landyking landyking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to collect Dubbo and Motan plugin metrics using Prometheus
3 participants
@oewang @observeralone @landyking