Skip to content

add motan plugin support #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 18, 2022
Merged

add motan plugin support #293

merged 12 commits into from
Nov 18, 2022

Conversation

oewang
Copy link
Contributor

@oewang oewang commented Nov 8, 2022 •
edited
Loading

  • support to the latest version

@observeralone
Copy link
Contributor

please base master to code and pr
you can use following command to rebase:

git checkout master
git pull origin master:master
git checkout {you branch}
git rebase -i master

oewang and others added 5 commits November 9, 2022 11:38
@oewang
feat: add motan plugin
5806b89
@oewang
feat: support motan multiple versions
f8b608d
@oewang
feat: complete test case
26beffe
@oewang
fix bug in motan async call to metrics collect
407b2f2
@oewang
build:
b0254ed 
- Modify the project package structure
- Modify the static member access modifier in the `MotanPluginConfig` class
landyking
landyking approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@landyking landyking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

oewang and others added 2 commits November 13, 2022 22:00
@oewang @observeralone
Update plugins/motan/src/main/java/com/megaease/easeagent/plugin/mota…
1fdc67f 
…n/config/MotanPluginConfig.java

Co-authored-by: yufu.deng <954068039@qq.com>
@oewang
- Addition the plugin description to the README file
30844e4 
- Close the `scope` in the `after` method of the interceptor.
- Add a note about the json library used for parameters and return values.
observeralone
observeralone reviewed Nov 18, 2022
View reviewed changes
observeralone
observeralone approved these changes Nov 18, 2022
View reviewed changes
@observeralone observeralone merged commit 50015b3 into megaease:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@observeralone observeralone observeralone approved these changes

@landyking landyking landyking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oewang @observeralone @landyking